Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2769203002: Use SaveLayerWithFlags to avoid cpu bitmaps in RoundedCornersImageSource (Closed)

Created:
3 years, 9 months ago by danakj
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, Matt Giuca, extensions-reviews_chromium.org, enne (OOO)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SaveLayerWithFlags to avoid cpu bitmaps in RoundedCornersImageSource The extention app items want a rounded corner and they do this by drawing into an intermediate target. We can use gfx::Canvas to achieve this effect without requiring us to make any bitmaps on the cpu during paint time. R=pkasting@chromium.org BUG=671433 Review-Url: https://codereview.chromium.org/2769203002 Cr-Commit-Position: refs/heads/master@{#459258} Committed: https://chromium.googlesource.com/chromium/src/+/23a49518b36200b125fb3e14f450e304668a4fc8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M chrome/browser/ui/app_list/extension_app_item.cc View 1 chunk +9 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
danakj
One more use for SaveLayerWithFlags from a CL I did a few days ago.
3 years, 9 months ago (2017-03-23 15:09:23 UTC) #1
Peter Kasting
LGTM
3 years, 9 months ago (2017-03-23 21:54:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769203002/1
3 years, 9 months ago (2017-03-23 21:56:04 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 22:30:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23a49518b36200b125fb3e14f450...

Powered by Google App Engine
This is Rietveld 408576698