Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2769193002: [ios] Expose TabModel underlying WebStateList. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Expose TabModel underlying WebStateList. In preparation of moving the ownership of WebStates to WebStateList, expose the TabModel's WebStateList (as some of the client will need to insert WebStates directly into the WebStateList). Rename TabModel's list of WebStateListObserver as it contains more than WebStateListObserverBridges. BUG=546222 Review-Url: https://codereview.chromium.org/2769193002 Cr-Commit-Position: refs/heads/master@{#459381} Committed: https://chromium.googlesource.com/chromium/src/+/ee21033fb48f99bb38854310b2705a9040c4116c

Patch Set 1 #

Patch Set 2 : Rebase on origin/master. #

Patch Set 3 : Rebase on origin/master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -18 lines) Patch
M ios/chrome/browser/tabs/tab_model.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 2 4 chunks +25 lines, -18 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-03-23 15:05:45 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 9 months ago (2017-03-23 16:53:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769193002/40001
3 years, 9 months ago (2017-03-24 09:36:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/393844) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-24 09:43:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769193002/40001
3 years, 9 months ago (2017-03-24 10:09:12 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 10:38:05 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ee21033fb48f99bb38854310b270...

Powered by Google App Engine
This is Rietveld 408576698