InspectorTraceAgent does not handle reloading blanket correctly

InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG=674404
Review-Url: https://codereview.chromium.org/2769153002
Cr-Commit-Position: refs/heads/master@{#459354}
Committed: https://chromium.googlesource.com/chromium/src/+/fa347f00f375a465b794912889249cbfa8b61826

[Takashi Toyoshima, 2017-03-23 11:08:35]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 11:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-23 11:09:40]

Description was changed from

==========
InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG=674404
==========

to

==========
InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG=674404
==========

[Takashi Toyoshima, 2017-03-23 11:09:41]

toyoshim@chromium.org changed reviewers:
+ caseq@chromium.org, dgozman@chromium.org

[Takashi Toyoshima, 2017-03-23 11:10:36]

Hi, this code is originally added by caseq, but I think now this code should
handle other reload types to work as you expected.

Could you take a look?

[commit-bot: I haz the power, 2017-03-23 12:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 12:48:40]

Dry run: This issue passed the CQ dry run.

[caseq, 2017-03-23 13:57:23]

thanks for the fix, lgtm!

[dgozman, 2017-03-24 00:30:39]

lgtm

[Takashi Toyoshima, 2017-03-24 03:24:52]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:25:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:28:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490325892168500, "parent_rev":
"d36381e3b65747fc7ea9df344129fa7ced3a0afe", "commit_rev":
"fa347f00f375a465b794912889249cbfa8b61826"}

[commit-bot: I haz the power, 2017-03-24 03:30:06]

Description was changed from

==========
InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG=674404
==========

to

==========
InspectorTraceAgent does not handle reloading blanket correctly

Now, InspectorTraceAgent show reloading blanket only for
FrameLoadTypeReload. But now FrameLoadTypeReloadMainResource and
FrameLoadTypeReloadBypassingCache are used instead.

This change modifies InspectorTracingAgent::frameStartedLoading()
to use isReloadLoadType() with FrameLoadType to know if the started
loading is for reload or not.

BUG=674404

Review-Url: https://codereview.chromium.org/2769153002
Cr-Commit-Position: refs/heads/master@{#459354}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa347f00f375a465b79491288924...
==========

[commit-bot: I haz the power, 2017-03-24 03:30:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa347f00f375a465b79491288924...