Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: ios/showcase/content_suggestions/BUILD.gn

Issue 2769063005: Add CSDataSource in showcase (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/showcase/content_suggestions/BUILD.gn
diff --git a/ios/showcase/content_suggestions/BUILD.gn b/ios/showcase/content_suggestions/BUILD.gn
index 39e4c63c04bc08a5f2bacae9343c9867f9a10513..829cc4e4fe96cb68095edbcb6836f160cc25589d 100644
--- a/ios/showcase/content_suggestions/BUILD.gn
+++ b/ios/showcase/content_suggestions/BUILD.gn
@@ -6,11 +6,19 @@ source_set("content_suggestions") {
sources = [
"sc_content_suggestions_coordinator.h",
"sc_content_suggestions_coordinator.mm",
+ "sc_content_suggestions_data_source.h",
+ "sc_content_suggestions_data_source.mm",
]
deps = [
"//base",
+ "//components/strings",
+ "//ios/chrome/app/strings",
"//ios/chrome/browser/ui/content_suggestions",
+ "//ios/chrome/browser/ui/content_suggestions/identifier",
"//ios/showcase/common",
+ "//ui/base",
+ "//ui/gfx",
+ "//url",
lpromero 2017/03/24 12:10:17 Idem, only NSString should crossover. We need to k
gambard 2017/03/24 15:12:49 So, based on your doc, should I keep it? :)
lpromero 2017/03/24 15:22:54 As of today, I'd say no, as people pushed back bef
]
libs = [ "UIKit.framework" ]
configs += [ "//build/config/compiler:enable_arc" ]
@@ -22,6 +30,9 @@ source_set("eg_tests") {
"sc_content_suggestions_egtest.mm",
]
deps = [
+ "//components/strings",
+ "//ios/chrome/app/strings",
+ "//ios/chrome/test/earl_grey:test_support",
"//ios/showcase/test",
"//ios/third_party/earl_grey",
]

Powered by Google App Engine
This is Rietveld 408576698