Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: ios/showcase/content_suggestions/BUILD.gn

Issue 2769063005: Add CSDataSource in showcase (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("content_suggestions") { 5 source_set("content_suggestions") {
6 sources = [ 6 sources = [
7 "sc_content_suggestions_coordinator.h", 7 "sc_content_suggestions_coordinator.h",
8 "sc_content_suggestions_coordinator.mm", 8 "sc_content_suggestions_coordinator.mm",
9 "sc_content_suggestions_data_source.h",
10 "sc_content_suggestions_data_source.mm",
9 ] 11 ]
10 deps = [ 12 deps = [
11 "//base", 13 "//base",
14 "//components/strings",
15 "//ios/chrome/app/strings",
12 "//ios/chrome/browser/ui/content_suggestions", 16 "//ios/chrome/browser/ui/content_suggestions",
17 "//ios/chrome/browser/ui/content_suggestions/identifier",
13 "//ios/showcase/common", 18 "//ios/showcase/common",
19 "//ui/base",
20 "//ui/gfx",
21 "//url",
lpromero 2017/03/24 12:10:17 Idem, only NSString should crossover. We need to k
gambard 2017/03/24 15:12:49 So, based on your doc, should I keep it? :)
lpromero 2017/03/24 15:22:54 As of today, I'd say no, as people pushed back bef
14 ] 22 ]
15 libs = [ "UIKit.framework" ] 23 libs = [ "UIKit.framework" ]
16 configs += [ "//build/config/compiler:enable_arc" ] 24 configs += [ "//build/config/compiler:enable_arc" ]
17 } 25 }
18 26
19 source_set("eg_tests") { 27 source_set("eg_tests") {
20 testonly = true 28 testonly = true
21 sources = [ 29 sources = [
22 "sc_content_suggestions_egtest.mm", 30 "sc_content_suggestions_egtest.mm",
23 ] 31 ]
24 deps = [ 32 deps = [
33 "//components/strings",
34 "//ios/chrome/app/strings",
35 "//ios/chrome/test/earl_grey:test_support",
25 "//ios/showcase/test", 36 "//ios/showcase/test",
26 "//ios/third_party/earl_grey", 37 "//ios/third_party/earl_grey",
27 ] 38 ]
28 configs += [ "//build/config/compiler:enable_arc" ] 39 configs += [ "//build/config/compiler:enable_arc" ]
29 } 40 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698