Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Issue 2769023004: Cloud Print process type: service -> cloud-print-service (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cloud Print process type: service -> cloud-print-service Renames the "service" process type (used only for Cloud Print) to "cloud-print-service", because it's such a good name for service processes, and nobody else is going to use the old service process type for anything new. BUG=654986, 690553 Review-Url: https://codereview.chromium.org/2769023004 Cr-Commit-Position: refs/heads/master@{#459483} Committed: https://chromium.googlesource.com/chromium/src/+/ad57bdd5ac229a7e0fb9b191413cc3057c6b6866

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/app/main_dll_loader_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_paths_win.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/service_process_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_main.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/crash/content/app/breakpad_win.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Ken Rockot(use gerrit already)
PTAL jam@ for chrome/ scottmg@ for components/crash
3 years, 9 months ago (2017-03-23 20:59:20 UTC) #7
scottmg
lgtm Please delete/update https://sites.google.com/a/chromium.org/dev/developers/design-documents/service-processes too.
3 years, 9 months ago (2017-03-23 21:08:20 UTC) #8
jam
lgtm
3 years, 9 months ago (2017-03-24 14:30:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769023004/20001
3 years, 9 months ago (2017-03-24 18:17:05 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:29:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ad57bdd5ac229a7e0fb9b191413c...

Powered by Google App Engine
This is Rietveld 408576698