components/autofill/content/renderer/password_form_conversion_utils.cc - Issue 2769023003: [Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 2769023003: [Password Manager] Check node visibility with isFocusable instead of hasNonEmptyLayoutSize (Closed)

Patch Set: Added comment to IsWebElementVisible Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc

index f128e0b4647cc6673a62357f25d573eeef1842ce..09f9e4be2958f98192f26aa29b5ed58c5fb9cd94 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc

@@ -356,7 +356,7 @@ void FoundVisiblePasswordAndVisibleUsernameBeforePassword(

!input_element->isTextField())

continue;

- if (!form_util::IsWebNodeVisible(*input_element))

+ if (!form_util::IsWebElementVisible(*input_element))

continue;

if (input_element->isPasswordField()) {

@@ -430,7 +430,7 @@ bool GetPasswordForm(

if (HasCreditCardAutocompleteAttributes(*input_element))

continue;

- bool element_is_invisible = !form_util::IsWebNodeVisible(*input_element);

+ bool element_is_invisible = !form_util::IsWebElementVisible(*input_element);

if (input_element->isTextField()) {

if (input_element->isPasswordField()) {

if (element_is_invisible && ignore_invisible_passwords)