Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2769013002: [wasm][asm.js] Fix a comment in the asm.js scanner. (Closed)

Created:
3 years, 9 months ago by bradnelson
Modified:
3 years, 9 months ago
Reviewers:
bradn, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Fix a comment in the asm.js scanner. BUG=v8:6090 R=marja@chromium.org Review-Url: https://codereview.chromium.org/2769013002 Cr-Commit-Position: refs/heads/master@{#44061} Committed: https://chromium.googlesource.com/v8/v8/+/ac5d006aad0ceeed59ce2fb1a9586bf2eb5c26ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/asmjs/asm-scanner.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
bradn
3 years, 9 months ago (2017-03-22 23:07:22 UTC) #4
marja
lgtm
3 years, 9 months ago (2017-03-23 12:04:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2769013002/1
3 years, 9 months ago (2017-03-23 12:34:02 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 12:35:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ac5d006aad0ceeed59ce2fb1a9586bf2eb5...

Powered by Google App Engine
This is Rietveld 408576698