Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm

Issue 2768933005: Use CollectionViewTextItem instead of a cast (Closed)
Patch Set: Remove MDFRoboto Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm b/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
index 782f7ccfe2549827c80da13e11a29573eee75973..199055f14811795739b951b8b0ba425393f451d0 100644
--- a/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
@@ -165,6 +165,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
initWithType:ItemTypeOtherDevicesHeader] autorelease];
otherDevicesHeader.text =
l10n_util::GetNSString(IDS_IOS_OPTIONS_CONTINUITY_LABEL);
+ otherDevicesHeader.textColor = [[MDCPalette greyPalette] tint500];
[model setHeader:otherDevicesHeader
forSectionWithIdentifier:SectionIdentifierOtherDevices];
[model addItem:[self handoffDetailItem]
@@ -176,6 +177,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
initWithType:ItemTypeWebServicesHeader] autorelease];
webServicesHeader.text =
l10n_util::GetNSString(IDS_IOS_OPTIONS_WEB_SERVICES_LABEL);
+ webServicesHeader.textColor = [[MDCPalette greyPalette] tint500];
[model setHeader:webServicesHeader
forSectionWithIdentifier:SectionIdentifierWebServices];
_showSuggestionsItem.reset([[self showSuggestionsSwitchItem] retain]);
@@ -338,21 +340,6 @@ typedef NS_ENUM(NSInteger, ItemType) {
return cell;
}
-- (UICollectionReusableView*)collectionView:(UICollectionView*)collectionView
- viewForSupplementaryElementOfKind:(NSString*)kind
- atIndexPath:(NSIndexPath*)indexPath {
- UICollectionReusableView* view = [super collectionView:collectionView
- viewForSupplementaryElementOfKind:kind
- atIndexPath:indexPath];
-
- MDCCollectionViewTextCell* textCell =
- base::mac::ObjCCast<MDCCollectionViewTextCell>(view);
- if (textCell) {
- textCell.textLabel.textColor = [[MDCPalette greyPalette] tint500];
- }
- return view;
-}
-
#pragma mark UICollectionViewDelegate
- (void)collectionView:(UICollectionView*)collectionView
didSelectItemAtIndexPath:(NSIndexPath*)indexPath {

Powered by Google App Engine
This is Rietveld 408576698