Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2768933003: [ash-md] Fixed ShelfBackgroundAnimator to not snap target values when being preempted. (Closed)

Created:
3 years, 9 months ago by bruthig
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[ash-md] Fixed ShelfBackgroundAnimator to not snap target values when being preempted. Snapping to the target values was causing the shelf to flicker when dragging a window while in OVERLAP mode. And on some platforms this contributed to the shelf incorrectly being painted as DEFAULT mode. BUG=695901 Review-Url: https://codereview.chromium.org/2749123003 Cr-Commit-Position: refs/heads/master@{#456892} (cherry picked from commit 27dd2542a15215360c4f4fc8eeca9d72780d5167) Review-Url: https://codereview.chromium.org/2768933003 . Cr-Commit-Position: refs/branch-heads/3029@{#391} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3af2743961f2dd4424ec6f802d832e0b193d6556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M ash/common/shelf/shelf_background_animator.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/shelf/shelf_background_animator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/shelf/shelf_background_animator_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
3 years, 9 months ago (2017-03-23 19:00:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3af2743961f2dd4424ec6f802d832e0b193d6556.

Powered by Google App Engine
This is Rietveld 408576698