Fix gn_all build on gcc 4.8

Fix gn_all build on gcc 4.8

BUG=697528
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2768923003
Cr-Commit-Position: refs/heads/master@{#459351}
Committed: https://chromium.googlesource.com/chromium/src/+/3e655172a781a71727269de3416ffba84d285ddd

[Tom (Use chromium acct), 2017-03-23 19:24:02]

sky@ ptal
This CL fixes the gcc build.  There should be no functional changes

[Tom (Use chromium acct), 2017-03-23 19:24:06]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:24:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 20:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 20:17:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-03-23 22:59:46]

Can you please describe what build errors you are seeing?

Also, are we adding a gcc 4.8 bot? If not, I'm not, I suspect stuff like this
will keep breaking.

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/media_stream_devices_controller.h (right):

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_stream_devices_controller.h:37: // Delegate
showing permission prompts.
Why does this need to move? What error happens with it in the private section of
the class?

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
File chrome/browser/ui/views/accessibility/invert_bubble_view.cc (right):

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
chrome/browser/ui/views/accessibility/invert_bubble_view.cc:87:
base::string16(), views::Label::CustomFont{original_font_list.Derive(
What gcc error does this generate?

[Tom (Use chromium acct), 2017-03-23 23:45:15]

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/media/webrtc...
File chrome/browser/media/webrtc/media_stream_devices_controller.h (right):

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/media/webrtc...
chrome/browser/media/webrtc/media_stream_devices_controller.h:37: // Delegate
showing permission prompts.
On 2017/03/23 22:59:46, sky wrote:
> Why does this need to move? What error happens with it in the private section
of
> the class?

Subclasses cannot derive from PermissionPromptDelegate (even if they are friend
classes) on gcc.

In file included from
../../chrome/browser/permissions/permission_request_manager_browsertest.cc:13:0:
../../chrome/browser/media/webrtc/media_stream_devices_controller.h:78:9: error:
'class MediaStreamDevicesController::PermissionPromptDelegate' is private
   class PermissionPromptDelegate {
         ^
../../chrome/browser/permissions/permission_request_manager_browsertest.cc:32:44:
error: within this context
     : public MediaStreamDevicesController::PermissionPromptDelegate {

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
File chrome/browser/ui/views/accessibility/invert_bubble_view.cc (right):

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
chrome/browser/ui/views/accessibility/invert_bubble_view.cc:87:
base::string16(), views::Label::CustomFont{original_font_list.Derive(
On 2017/03/23 22:59:46, sky wrote:
> What gcc error does this generate?

error: no matching function for call to 'views::Label::Label(base::string16,
<brace-enclosed initializer list>)'

[sky, 2017-03-24 02:41:50]

Thanks for documenting what errors you got. LGTM

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
File chrome/browser/ui/views/accessibility/invert_bubble_view.cc (right):

https://codereview.chromium.org/2768923003/diff/1/chrome/browser/ui/views/acc...
chrome/browser/ui/views/accessibility/invert_bubble_view.cc:87:
base::string16(), views::Label::CustomFont{original_font_list.Derive(
On 2017/03/23 23:45:14, Tom Anderson wrote:
> On 2017/03/23 22:59:46, sky wrote:
> > What gcc error does this generate?
> 
> error: no matching function for call to 'views::Label::Label(base::string16,
> <brace-enclosed initializer list>)'

I'm surprised by this one given FontList::Derive returns a FontList.

[Tom (Use chromium acct), 2017-03-24 03:11:38]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-03-24 03:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:17:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490325098351670, "parent_rev":
"06636331ca1fc8418e59dfd06c6d62bcf8111c63", "commit_rev":
"3e655172a781a71727269de3416ffba84d285ddd"}

[commit-bot: I haz the power, 2017-03-24 03:18:45]

Description was changed from

==========
Fix gn_all build on gcc 4.8

BUG=697528
R=sky@chromium.org
==========

to

==========
Fix gn_all build on gcc 4.8

BUG=697528
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2768923003
Cr-Commit-Position: refs/heads/master@{#459351}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e655172a781a71727269de3416f...
==========

[commit-bot: I haz the power, 2017-03-24 03:18:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e655172a781a71727269de3416f...

[raymes, 2017-04-13 01:11:22]

On 2017/03/24 03:18:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/3e655172a781a71727269de3416f...

Will there be a bot to catch these errors? I was about to change the
MediaStreamDevicesController code back to how it was before because it's clearly
better the way it was!

[Tom (Use chromium acct), 2017-04-13 01:13:51]

On 2017/04/13 01:11:22, raymes wrote:
> On 2017/03/24 03:18:46, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/3e655172a781a71727269de3416f...
> 
> Will there be a bot to catch these errors? I was about to change the
> MediaStreamDevicesController code back to how it was before because it's
clearly
> better the way it was!

There will be an FYI bot, but probably nothing on the main waterfall