Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2768913002: Enable native symbol resolving on Windows again (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable native symbol resolving on Windows again This is needed when dumping stack traces. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c32bfb4e3430fb84edf6dab393a248db220ac528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M runtime/vm/native_symbol_win.cc View 5 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
3 years, 9 months ago (2017-03-22 19:48:58 UTC) #2
Cutch
lgtm
3 years, 9 months ago (2017-03-22 19:49:49 UTC) #4
Florian Schneider
3 years, 9 months ago (2017-03-22 19:51:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c32bfb4e3430fb84edf6dab393a248db220ac528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698