Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/native_symbol_win.cc

Issue 2768913002: Enable native symbol resolving on Windows again (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_symbol_win.cc
diff --git a/runtime/vm/native_symbol_win.cc b/runtime/vm/native_symbol_win.cc
index 3b5dddf252fa77531e83f49b42223dd9e1e21787..fa57d56cd733a5461e0d450019e569a6f1ae5683 100644
--- a/runtime/vm/native_symbol_win.cc
+++ b/runtime/vm/native_symbol_win.cc
@@ -20,7 +20,6 @@ void NativeSymbolResolver::InitOnce() {
ASSERT(running_ == false);
lock_ = new Mutex();
running_ = true;
-#if 0
SymSetOptions(SYMOPT_UNDNAME | SYMOPT_DEFERRED_LOADS);
HANDLE hProcess = GetCurrentProcess();
if (!SymInitialize(hProcess, NULL, TRUE)) {
@@ -28,7 +27,6 @@ void NativeSymbolResolver::InitOnce() {
printf("Failed to init NativeSymbolResolver (SymInitialize %d)\n", error);
return;
}
-#endif
}
@@ -38,13 +36,11 @@ void NativeSymbolResolver::ShutdownOnce() {
return;
}
running_ = false;
-#if 0
HANDLE hProcess = GetCurrentProcess();
if (!SymCleanup(hProcess)) {
DWORD error = GetLastError();
printf("Failed to shutdown NativeSymbolResolver (SymCleanup %d)\n", error);
}
-#endif
}
@@ -60,7 +56,6 @@ char* NativeSymbolResolver::LookupSymbolName(uintptr_t pc, uintptr_t* start) {
if (start != NULL) {
*start = NULL;
}
-#if 0
memset(&buffer[0], 0, sizeof(buffer));
HANDLE hProcess = GetCurrentProcess();
DWORD64 address = static_cast<DWORD64>(pc);
@@ -72,8 +67,6 @@ char* NativeSymbolResolver::LookupSymbolName(uintptr_t pc, uintptr_t* start) {
return NULL;
}
return strdup(pSymbol->Name);
-#endif
- return NULL;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698