InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
Review-Url: https://codereview.chromium.org/2768883003
Cr-Commit-Position: refs/heads/master@{#459682}
Committed: https://chromium.googlesource.com/chromium/src/+/722be98f7e4d7551710fb9cf30674750cdd0d857

[Matt Giuca, 2017-03-23 00:35:33]

Description was changed from

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
==========

to

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android again!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
==========

[Matt Giuca, 2017-03-23 00:35:54]

Description was changed from

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android again!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
==========

to

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
==========

[Matt Giuca, 2017-03-23 00:36:02]

mgiuca@chromium.org changed reviewers:
+ boliu@chromium.org, jbudorick@chromium.org

[Matt Giuca, 2017-03-23 00:36:02]

See discussion on bug (and the last few comments on
https://codereview.chromium.org/2706403014) for more details.

boliu: For OWNERS.
jbudorick: For the go-ahead to land this. As per the bug, this *will* pass the
try bots but break on the waterfall unless https://crbug.com/704013 is fixed, so
I will wait to land this when you think it is.

[Matt Giuca, 2017-03-23 00:36:13]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:36:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:49:25]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-03-23 03:17:27]

lgtm

[Matt Giuca, 2017-03-26 23:44:10]

On 2017/03/23 03:17:27, boliu wrote:
> lgtm

Instead of waiting for infra to confirm if it's fixed, I'll just go ahead and
land this and watch the tree (it's AM here in Sydney) and revert if necessary.

[Matt Giuca, 2017-03-26 23:44:15]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-03-26 23:44:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-26 23:55:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490571855159180, "parent_rev":
"6e14d3fe0ec345ca2955b4f1eb4416f0d3e1f00a", "commit_rev":
"722be98f7e4d7551710fb9cf30674750cdd0d857"}

[commit-bot: I haz the power, 2017-03-26 23:56:41]

Description was changed from

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013
==========

to

==========
InstalledAppProviderTest: Remove explicit "final" (requires Java 8).

This change requires Java 8, which should now be enabled on all Android
builders (see https://crbug.com/704013). This small change serves as a
test to make sure we aren't building with Java 7 on any bots.

Sheriffs: Please revert this if it fails to compile on Android!

This takes advantage of the new "effectively final" rule in Java 8: an
explicit "final" is not required on a captured variable as it is added
automatically by the compiler.

BUG=704013

Review-Url: https://codereview.chromium.org/2768883003
Cr-Commit-Position: refs/heads/master@{#459682}
Committed:
https://chromium.googlesource.com/chromium/src/+/722be98f7e4d7551710fb9cf3067...
==========

[commit-bot: I haz the power, 2017-03-26 23:56:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/722be98f7e4d7551710fb9cf3067...