Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2768873007: Add Support to Get a COM STA Task Runner from the Task Scheduler API (Closed)

Created:
3 years, 9 months ago by robliao
Modified:
3 years, 8 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Support to Get a COM STA Task Runner from the Task Scheduler API This also adds support for COM STA Task Runner for TaskSchedulerImpl as well as ScopedTaskScheduler. BUG=662122 Review-Url: https://codereview.chromium.org/2768873007 Cr-Commit-Position: refs/heads/master@{#460430} Committed: https://chromium.googlesource.com/chromium/src/+/75dd50b325a709221dd971e61eb3e6f53de1a8aa

Patch Set 1 #

Total comments: 6

Patch Set 2 : Partial CR Feedback #

Patch Set 3 : CR Feedback #

Total comments: 2

Patch Set 4 : Simplify COM Init for ScopedTaskScheduler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -2 lines) Patch
M base/task_scheduler/post_task.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M base/task_scheduler/post_task.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M base/test/scoped_task_scheduler.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M base/test/scoped_task_scheduler.cc View 1 2 3 5 chunks +32 lines, -0 lines 0 comments Download
M base/test/scoped_task_scheduler_unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
robliao
3 years, 9 months ago (2017-03-27 18:53:25 UTC) #6
fdoray
https://codereview.chromium.org/2768873007/diff/1/base/task_scheduler/post_task.h File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2768873007/diff/1/base/task_scheduler/post_task.h#newcode179 base/task_scheduler/post_task.h:179: // SingleThreadTaskRunner. Different SingleThreadTaskRunners may be associated // The ...
3 years, 9 months ago (2017-03-27 20:11:50 UTC) #7
robliao
https://codereview.chromium.org/2768873007/diff/1/base/task_scheduler/post_task.h File base/task_scheduler/post_task.h (right): https://codereview.chromium.org/2768873007/diff/1/base/task_scheduler/post_task.h#newcode179 base/task_scheduler/post_task.h:179: // SingleThreadTaskRunner. Different SingleThreadTaskRunners may be associated On 2017/03/27 ...
3 years, 9 months ago (2017-03-27 20:28:05 UTC) #8
robliao
https://codereview.chromium.org/2768873007/diff/1/base/test/scoped_task_scheduler.cc File base/test/scoped_task_scheduler.cc (right): https://codereview.chromium.org/2768873007/diff/1/base/test/scoped_task_scheduler.cc#newcode178 base/test/scoped_task_scheduler.cc:178: PostTask(MakeUnique<internal::Task>( On 2017/03/27 20:28:05, robliao wrote: > On 2017/03/27 ...
3 years, 9 months ago (2017-03-27 21:32:32 UTC) #10
fdoray
https://codereview.chromium.org/2768873007/diff/1/base/test/scoped_task_scheduler.cc File base/test/scoped_task_scheduler.cc (right): https://codereview.chromium.org/2768873007/diff/1/base/test/scoped_task_scheduler.cc#newcode178 base/test/scoped_task_scheduler.cc:178: PostTask(MakeUnique<internal::Task>( On 2017/03/27 21:32:32, robliao wrote: > On 2017/03/27 ...
3 years, 8 months ago (2017-03-28 14:14:46 UTC) #11
robliao
https://codereview.chromium.org/2768873007/diff/60001/base/test/scoped_task_scheduler.cc File base/test/scoped_task_scheduler.cc (right): https://codereview.chromium.org/2768873007/diff/60001/base/test/scoped_task_scheduler.cc#newcode188 base/test/scoped_task_scheduler.cc:188: RunLoop().RunUntilIdle(); On 2017/03/28 14:14:46, fdoray wrote: > RunLoop().RunUntilIdle() runs ...
3 years, 8 months ago (2017-03-28 17:15:02 UTC) #12
fdoray
lgtm
3 years, 8 months ago (2017-03-29 12:14:05 UTC) #17
gab
lgtm
3 years, 8 months ago (2017-03-29 17:01:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768873007/80001
3 years, 8 months ago (2017-03-29 17:02:52 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 17:12:18 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/75dd50b325a709221dd971e61eb3...

Powered by Google App Engine
This is Rietveld 408576698