Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2768773003: Make layout-dev@ address on the TEAM line fully qualified (Closed)

Created:
3 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 9 months ago
Reviewers:
ymzhang1, ymzhang, eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, abarth-chromium, dglazkov+blink, jchaffraix+rendering, blink-reviews, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make layout-dev@ address on the TEAM line fully qualified As suggested at https://codereview.chromium.org/2627093006/#msg12 Updating content/browser/hyphenation/OWNERS would make the presubmit unhappy as it has the COMPONENT line set to Internals>Core. So, this CL doesn't touch it. BUG=679905 Review-Url: https://codereview.chromium.org/2768773003 Cr-Commit-Position: refs/heads/master@{#458801} Committed: https://chromium.googlesource.com/chromium/src/+/27dc20f2cd65e5b0f6178fd98a756fccdef8490c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/hyphenation/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
tyoshino (SeeGerritForStatus)
3 years, 9 months ago (2017-03-22 09:40:10 UTC) #3
tyoshino (SeeGerritForStatus)
This is the presubmit error I got when I tried to update content/browser/hyphenation/OWNERS. checkteamtags.py lists ...
3 years, 9 months ago (2017-03-22 09:41:13 UTC) #4
ymzhang1
On 2017/03/22 09:41:13, tyoshino wrote: > This is the presubmit error I got when I ...
3 years, 9 months ago (2017-03-22 15:27:24 UTC) #5
eae
LGTM
3 years, 9 months ago (2017-03-22 15:33:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768773003/1
3 years, 9 months ago (2017-03-22 16:37:41 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 18:10:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27dc20f2cd65e5b0f6178fd98a75...

Powered by Google App Engine
This is Rietveld 408576698