Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2768653002: Cleanup: remove someof MediaTrack's stable flags and correct ImageCapture ones (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
Reviewers:
tkent, Guido Urdaneta
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch, tommyw+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove some of MediaTrack's stable flags and correct ImageCapture ones This CL removes MediaConstraints and MediaGetSettings since they are stable and they make reading idl's etc verbose when interacting with other, non-stable, flags. Also correction of the use of ImageCapture flag: s/RuntimeEnabled=ImageCapture/OriginTrialEnabled=ImageCapture/ No code changes per se. BUG=701849 Review-Url: https://codereview.chromium.org/2768653002 Cr-Commit-Position: refs/heads/master@{#458990} Committed: https://chromium.googlesource.com/chromium/src/+/6093997931808df404b0350cfa4630a3a8bc6143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -66 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaDevices.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaTrackCapabilities.idl View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaTrackConstraintSet.idl View 1 chunk +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
mcasas
guidou@ cleanup, ptal
3 years, 9 months ago (2017-03-21 22:00:56 UTC) #6
Guido Urdaneta
lgtm
3 years, 9 months ago (2017-03-22 10:42:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768653002/1
3 years, 9 months ago (2017-03-22 13:33:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391500)
3 years, 9 months ago (2017-03-22 13:39:03 UTC) #14
mcasas
tkent@ RS plz : - the two flag removals in RuntimeEnabledFeatures.json5 (they are both Stable).
3 years, 9 months ago (2017-03-22 15:06:27 UTC) #16
tkent
lgtm
3 years, 9 months ago (2017-03-22 22:24:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768653002/1
3 years, 9 months ago (2017-03-22 22:32:18 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/412823)
3 years, 9 months ago (2017-03-23 01:41:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768653002/1
3 years, 9 months ago (2017-03-23 02:02:24 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 02:58:08 UTC) #26
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6093997931808df404b0350cfa46...

Powered by Google App Engine
This is Rietveld 408576698