Avoid setting visual viewport location/scale if it's infinite/NaN

Avoid setting visual viewport location/scale if it's infinite/NaN

This CL replaces CHECKs added in r457920 with early-outs. Crash stats
revealed we can enter this method with the location argument being
infinity. Seems to only happen on ChromeOS with touchpad pinch-zoom.

BUG=702711
Review-Url: https://codereview.chromium.org/2768603002
Cr-Commit-Position: refs/heads/master@{#458548}
Committed: https://chromium.googlesource.com/chromium/src/+/582807cc0713109b51ec8e1adca6d04879a00c18

[bokan, 2017-03-21 18:45:25]

Description was changed from

==========
Avoid setting visual viewport location/scale if it's infinite/NaN

This CL replaces CHECKs added in r457920 with early-outs.

BUG=702711
==========

to

==========
Avoid setting visual viewport location/scale if it's infinite/NaN

This CL replaces CHECKs added in r457920 with early-outs. Crash stats
revealed we can enter this method with the location argument being
infinity. Seems to only happen on ChromeOS with touchpad pinch-zoom.

BUG=702711
==========

[bokan, 2017-03-21 18:45:25]

bokan@chromium.org changed reviewers:
+ skobes@chromium.org

[skobes, 2017-03-21 19:06:49]

lgtm

https://codereview.chromium.org/2768603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/VisualViewport.cpp (right):

https://codereview.chromium.org/2768603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/VisualViewport.cpp:313: // TODO(bokan):
Looks lie we call into setScaleAndLocation with infinity for
typo: lie -> like

[bokan, 2017-03-21 19:19:30]

https://codereview.chromium.org/2768603002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/VisualViewport.cpp (right):

https://codereview.chromium.org/2768603002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/VisualViewport.cpp:313: // TODO(bokan):
Looks lie we call into setScaleAndLocation with infinity for
On 2017/03/21 19:06:49, skobes wrote:
> typo: lie -> like

Done.

[bokan, 2017-03-21 19:19:35]

The CQ bit was checked by bokan@chromium.org

[bokan, 2017-03-21 19:19:35]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2768603002/#ps60001
(title: "Undo another unintended change")

[commit-bot: I haz the power, 2017-03-21 19:20:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 21:16:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490123975283100,
"parent_rev": "e99aa1b8eb87c34de393460aa01f61d4cae6ce55", "commit_rev":
"582807cc0713109b51ec8e1adca6d04879a00c18"}

[commit-bot: I haz the power, 2017-03-21 21:16:54]

Description was changed from

==========
Avoid setting visual viewport location/scale if it's infinite/NaN

This CL replaces CHECKs added in r457920 with early-outs. Crash stats
revealed we can enter this method with the location argument being
infinity. Seems to only happen on ChromeOS with touchpad pinch-zoom.

BUG=702711
==========

to

==========
Avoid setting visual viewport location/scale if it's infinite/NaN

This CL replaces CHECKs added in r457920 with early-outs. Crash stats
revealed we can enter this method with the location argument being
infinity. Seems to only happen on ChromeOS with touchpad pinch-zoom.

BUG=702711

Review-Url: https://codereview.chromium.org/2768603002
Cr-Commit-Position: refs/heads/master@{#458548}
Committed:
https://chromium.googlesource.com/chromium/src/+/582807cc0713109b51ec8e1adca6...
==========

[commit-bot: I haz the power, 2017-03-21 21:16:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/582807cc0713109b51ec8e1adca6...