Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2768463004: fix union test deps (Closed)

Created:
3 years, 9 months ago by damargulis
Modified:
3 years, 9 months ago
Reviewers:
yzshen1, jbroman, alokp
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix union test dependencies. This moves the test_unions.mojom out of test_interfaces_experimental and deletes test_interfaces_experimental. test_unions.mojom is moved into test_interfaces so it is loaded with the rest of the mojo dependencies. This is part of moving the mojo tests into LayoutTest, as started in CL:2744763002, and fixes a bug introduced in that CL causing union_test.html to timeout since it was unable to find test_unions.mojom. This also removes any other calls to test_interfaces_experimental. BUG=703813 Review-Url: https://codereview.chromium.org/2768463004 Cr-Commit-Position: refs/heads/master@{#458746} Committed: https://chromium.googlesource.com/chromium/src/+/1d0cdafbcdff0d46261536f4c1881b673ce71ec8

Patch Set 1 #

Patch Set 2 : remove calls to test_interfaces_experimental #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M mojo/edk/js/tests/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
alokp
lgtm Please format the patch description as described here: https://www.chromium.org/developers/contributing-code#TOC-Writing-change-list-descriptions
3 years, 9 months ago (2017-03-21 23:48:02 UTC) #4
yzshen1
lgtm
3 years, 9 months ago (2017-03-21 23:53:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768463004/20001
3 years, 9 months ago (2017-03-22 01:04:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 02:20:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768463004/20001
3 years, 9 months ago (2017-03-22 04:19:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 06:20:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768463004/20001
3 years, 9 months ago (2017-03-22 14:31:22 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 14:37:39 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d0cdafbcdff0d46261536f4c188...

Powered by Google App Engine
This is Rietveld 408576698