Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2768443003: [regexp] Fold repeated assertions (Closed)

Created:
3 years, 9 months ago by jgruber
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Fold repeated assertions For instance, /\b\b\b\B\B\B/ is folded into the equivalent /\b\B/. BUG=v8:6126 Review-Url: https://codereview.chromium.org/2768443003 Cr-Commit-Position: refs/heads/master@{#44004} Committed: https://chromium.googlesource.com/v8/v8/+/c8e4c8b9263b5009716804f06f39225a9dd7fc68

Patch Set 1 #

Patch Set 2 : Simpler solution during parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/regexp/regexp-parser.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jgruber
Hi Yang, please take a look. This folds word, line, and input boundary assertions.
3 years, 9 months ago (2017-03-21 15:52:48 UTC) #10
Yang
On 2017/03/21 15:52:48, jgruber wrote: > Hi Yang, please take a look. This folds word, ...
3 years, 9 months ago (2017-03-22 09:23:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768443003/20001
3 years, 9 months ago (2017-03-22 09:27:11 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 09:28:35 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c8e4c8b9263b5009716804f06f39225a9dd...

Powered by Google App Engine
This is Rietveld 408576698