Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl |
| diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl |
| index d3a8c1242170c32ec31a55b466786461d969c394..5ac6b99600ac1a790a238ab9e323e5bd98a62e8a 100644 |
| --- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl |
| +++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl |
| @@ -246,10 +246,10 @@ const v8::FunctionCallbackInfo<v8::Value>& info |
| {##############################################################################} |
| -{% macro attribute_cache_property_callback(attribute) %} |
| -v8::Local<v8::Private> {{v8_class_or_partial}}::{{attribute.name}}CachedAccessorCallback(v8::Isolate* isolate) |
| +{% macro attribute_cache_property_key(attribute) %} |
|
Yuki
2017/03/24 07:00:29
Should this be attribute_cache"d"_property_key to
peria
2017/03/24 08:44:34
Done.
|
| +v8::Local<v8::Private> {{v8_class_or_partial}}::{{attribute.name}}CachedPropertyKey(v8::Isolate* isolate) |
| { |
| - return V8PrivateProperty::get{{attribute.cached_accessor_name}}(isolate).getPrivate(); |
| + return V8PrivateProperty::get{{attribute.cached_accessor_name}}(isolate).getPrivate(); |
| } |
| {% endmacro %} |
| @@ -480,7 +480,7 @@ const v8::FunctionCallbackInfo<v8::Value>& info |
| {% set property_attribute = 'static_cast<v8::PropertyAttribute>(%s)' % |
| ' | '.join(attribute.property_attributes) %} |
| {% set cached_accessor_callback = |
| - '%s::%sCachedAccessorCallback' % (v8_class_or_partial, attribute.name) |
| + '%s::%sCachedPropertyKey' % (v8_class_or_partial, attribute.name) |
| if attribute.is_cached_accessor else |
| 'nullptr' %} |
| {% set holder_check = 'V8DOMConfiguration::DoNotCheckHolder' |