Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2768383003: DevTools: Fixes regression in cookies tab in Network panel having no output (Closed)

Created:
3 years, 9 months ago by phulce
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

DevTools: Fixes regression in cookies tab in Network panel having no output Clicking on a request in the Network panel and selecting the cookies tab resulted in no output in this tab, despite there being cookies set. This appears to be a regression in https://codereview.chromium.org/2714913002 BUG=702940 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2760013002 Cr-Commit-Position: refs/heads/master@{#458847} (cherry picked from commit b8fba9d8708e06e1543bc3d9fe589640c8853137) Review-Url: https://codereview.chromium.org/2768383003 Cr-Commit-Position: refs/branch-heads/3029@{#400} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4ef1eee5f993e196c8ad92346ea9ba7e1854e722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
phulce
needs lgtm from committer
3 years, 9 months ago (2017-03-23 20:13:27 UTC) #2
dgozman
lgtm
3 years, 9 months ago (2017-03-24 00:27:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768383003/1
3 years, 9 months ago (2017-03-24 00:31:23 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 00:35:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ef1eee5f993e196c8ad92346ea9...

Powered by Google App Engine
This is Rietveld 408576698