[Doodle] Pass parameters to the server endpoint

[Doodle] Pass parameters to the server endpoint

ntp:1 identifies the request as being for Chrome NTP
graybg:0/1 says whether we want an image with gray background

BUG=690467
Review-Url: https://codereview.chromium.org/2768333002
Cr-Commit-Position: refs/heads/master@{#459179}
Committed: https://chromium.googlesource.com/chromium/src/+/53a9a9ad5cc4d43822d530eab0aa951b1a12a503

[Marc Treib, 2017-03-23 15:49:17]

treib@chromium.org changed reviewers:
+ fhorschig@chromium.org

[Marc Treib, 2017-03-23 15:49:18]

PTAL!

[fhorschig, 2017-03-23 16:25:48]

lgtm with ifdef

https://codereview.chromium.org/2768333002/diff/20001/chrome/browser/doodle/d...
File chrome/browser/doodle/doodle_service_factory.cc (right):

https://codereview.chromium.org/2768333002/diff/20001/chrome/browser/doodle/d...
chrome/browser/doodle/doodle_service_factory.cc:14: #include
"chrome/browser/android/chrome_feature_list.h"
As discussed: ifdef for Desktop.

[Marc Treib, 2017-03-23 17:15:53]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[Marc Treib, 2017-03-23 17:16:02]

https://codereview.chromium.org/2768333002/diff/20001/chrome/browser/doodle/d...
File chrome/browser/doodle/doodle_service_factory.cc (right):

https://codereview.chromium.org/2768333002/diff/20001/chrome/browser/doodle/d...
chrome/browser/doodle/doodle_service_factory.cc:14: #include
"chrome/browser/android/chrome_feature_list.h"
On 2017/03/23 16:25:48, fhorschig wrote:
> As discussed: ifdef for Desktop.

Done.

[commit-bot: I haz the power, 2017-03-23 17:16:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 17:44:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 17:44:50]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Marc Treib, 2017-03-23 17:48:40]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:49:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:23:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:23:34]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Marc Treib, 2017-03-23 18:40:46]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 18:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:18:22]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-23 19:23:24]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-03-23 19:23:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
fhorschig@chromium.org
Link to the patchset: https://codereview.chromium.org/2768333002/#ps40001
(title: "ifdef android")

[commit-bot: I haz the power, 2017-03-23 19:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:31:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490297004810460,
"parent_rev": "d8860857f5aa2a2a358c31c1122eccca7188faf9", "commit_rev":
"53a9a9ad5cc4d43822d530eab0aa951b1a12a503"}

[commit-bot: I haz the power, 2017-03-23 19:33:41]

Description was changed from

==========
[Doodle] Pass parameters to the server endpoint

ntp:1 identifies the request as being for Chrome NTP
graybg:0/1 says whether we want an image with gray background

BUG=690467
==========

to

==========
[Doodle] Pass parameters to the server endpoint

ntp:1 identifies the request as being for Chrome NTP
graybg:0/1 says whether we want an image with gray background

BUG=690467

Review-Url: https://codereview.chromium.org/2768333002
Cr-Commit-Position: refs/heads/master@{#459179}
Committed:
https://chromium.googlesource.com/chromium/src/+/53a9a9ad5cc4d43822d530eab0aa...
==========

[commit-bot: I haz the power, 2017-03-23 19:33:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53a9a9ad5cc4d43822d530eab0aa...