chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc - Issue 276833002: Make the App Info Dialog appear modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 276833002: Make the App Info Dialog appear modal (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added new browser test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/apps/app_info_dialog.h ('K') | « chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm ('k') | ui/app_list/views/app_list_view.h » ('j') | ui/app_list/views/app_list_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

index ce79b3b21b83158a48b73f1be3f56463306b2fa9..5a12e3039814c8019c031c19cfb5b0c8bd10beb7 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

@@ -17,12 +17,15 @@

#include "ui/views/window/dialog_delegate.h"

void ShowAppInfoDialog(gfx::NativeWindow parent_window,

+ gfx::Rect dialog_widget_bounds,

Profile* profile,

const extensions::Extension* app,

const base::Closure& close_callback) {

- CreateBrowserModalDialogViews(

+ views::Widget* dialog = CreateBrowserModalDialogViews(

new AppInfoDialog(parent_window, profile, app, close_callback),

- parent_window)->Show();

+ parent_window);

+ dialog->SetBounds(dialog_widget_bounds);

+ dialog->Show();

}

AppInfoDialog::AppInfoDialog(gfx::NativeWindow parent_window,