FrameFetchContext should respect BypassingCache

FrameFetchContext should respect BypassingCache

Existing logic in determineWebCachePolicy() respects request conditions
such as request being a conditional, and requesting method being POST,
even for FrameLoadTypeReloadBypassingCache.

But, BypassingCache is stronger condition for cache handling, and should
overwrite ValidatingCacheData.

BUG=704431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2768293002
Cr-Commit-Position: refs/heads/master@{#460718}
Committed: https://chromium.googlesource.com/chromium/src/+/d6744241b196c16f0946a00301aebeb7672d4166

[Takashi Toyoshima, 2017-03-23 06:31:49]

Description was changed from

==========
FrameFetchContext should respect BypassingCache

Existing logic in determineWebCachePolicy() respects request conditions
such as request being a conditional, and requesting method being POST,
even for FrameLoadTypeReloadBypassingCache.

But, BypassingCache is stronger condition for cache handling, and should
overwrite ValidatingCacheData.

BUG=704431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
FrameFetchContext should respect BypassingCache

Existing logic in determineWebCachePolicy() respects request conditions
such as request being a conditional, and requesting method being POST,
even for FrameLoadTypeReloadBypassingCache.

But, BypassingCache is stronger condition for cache handling, and should
overwrite ValidatingCacheData.

BUG=704431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Takashi Toyoshima, 2017-03-23 06:31:49]

toyoshim@chromium.org changed reviewers:
+ japhet@chromium.org, kinuko@chromium.org, yhirano@chromium.org

[Takashi Toyoshima, 2017-03-23 06:32:26]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 06:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 07:51:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 07:51:04]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-03-28 21:40:34]

LGTM. Does this need a test?

[kinuko, 2017-03-29 05:50:05]

(didn't realize this is a separate change) lgtm, this makes sense to me

[Takashi Toyoshima, 2017-03-29 08:27:38]

I suspended this work for a while for a sheriff duty, and didn't publish (that's
why kinuko could not notice this CL).

Now I resume this work and will update a series of CLs to have tests.

[Takashi Toyoshima, 2017-03-29 09:55:50]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 09:56:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2017-03-29 09:56:26]

PTAL tests of Patch Set 3.

[commit-bot: I haz the power, 2017-03-29 11:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:03:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yhirano, 2017-03-29 11:22:52]

lgtm

[Takashi Toyoshima, 2017-03-30 08:52:39]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-30 08:52:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
japhet@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2768293002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-30 08:52:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 10:34:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490863959390130,
"parent_rev": "2dc62d75bfe14b3d5cd2a6b7cdd1d76515f29498", "commit_rev":
"d6744241b196c16f0946a00301aebeb7672d4166"}

[commit-bot: I haz the power, 2017-03-30 10:35:43]

Description was changed from

==========
FrameFetchContext should respect BypassingCache

Existing logic in determineWebCachePolicy() respects request conditions
such as request being a conditional, and requesting method being POST,
even for FrameLoadTypeReloadBypassingCache.

But, BypassingCache is stronger condition for cache handling, and should
overwrite ValidatingCacheData.

BUG=704431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
FrameFetchContext should respect BypassingCache

Existing logic in determineWebCachePolicy() respects request conditions
such as request being a conditional, and requesting method being POST,
even for FrameLoadTypeReloadBypassingCache.

But, BypassingCache is stronger condition for cache handling, and should
overwrite ValidatingCacheData.

BUG=704431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2768293002
Cr-Commit-Position: refs/heads/master@{#460718}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6744241b196c16f0946a00301ae...
==========

[commit-bot: I haz the power, 2017-03-30 10:35:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d6744241b196c16f0946a00301ae...