Remove isTreeScopeRoot.

Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

after getting an element from the rootNode's treeScope id map as a way to
check if the element is inside the rootNode, but if isTreeScopeRoot was
true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900
Review-Url: https://codereview.chromium.org/2768263006
Cr-Commit-Position: refs/heads/master@{#459734}
Committed: https://chromium.googlesource.com/chromium/src/+/7166178c862576e32636718ec0ec5ab29eb9a453

[esprehn, 2017-03-24 23:45:38]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 23:46:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2017-03-25 00:54:40]

Description was changed from

==========
Remove isTreeScopeRoot.

BUG=
==========

to

==========
Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

as a way to check if the element is inside the rootNode, but if isTreeScopeRoot
was true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900
==========

[esprehn, 2017-03-25 00:54:40]

esprehn@chromium.org changed reviewers:
+ hayato@chromium.org, rune@opera.com, sashab@chromium.org

[esprehn, 2017-03-25 00:55:18]

Description was changed from

==========
Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

as a way to check if the element is inside the rootNode, but if isTreeScopeRoot
was true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900
==========

to

==========
Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

after getting an element from the rootNode's treeScope id map as a way to
check if the element is inside the rootNode, but if isTreeScopeRoot was
true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900
==========

[commit-bot: I haz the power, 2017-03-25 01:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 01:28:28]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-03-27 05:11:25]

Cool idea, LGTM.

BTW you should send these style reviews to meade@, instead of me, from now on.

[hayato, 2017-03-27 06:46:20]

LGTM

It looks Node::isDescendantOf(other) does the similar check,
other.isTreeScope(), we do not need to check isTreeScopeRoot() before calling
isDescendantOf().

[esprehn, 2017-03-27 08:13:14]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:13:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 09:39:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490602394133370, "parent_rev":
"b2cdcbfc13078c618e722c988e5afc0a5d435e74", "commit_rev":
"7166178c862576e32636718ec0ec5ab29eb9a453"}

[commit-bot: I haz the power, 2017-03-27 09:40:08]

Description was changed from

==========
Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

after getting an element from the rootNode's treeScope id map as a way to
check if the element is inside the rootNode, but if isTreeScopeRoot was
true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900
==========

to

==========
Remove isTreeScopeRoot and just rely on isDescendantOf instead.

Today the SelectorQuery code does:
isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)

after getting an element from the rootNode's treeScope id map as a way to
check if the element is inside the rootNode, but if isTreeScopeRoot was
true then isDescendantOf must also be true, so all this was doing was saving
a function call and a few branches for the elements with the matching id. This
doesn't seem worth the added complexity, so lets just rely on isDescendantOf.

This also lets us remove isTreeScopeRoot function, which is semantically
equivalent to Node::isTreeScope() anyway. 


BUG=703900

Review-Url: https://codereview.chromium.org/2768263006
Cr-Commit-Position: refs/heads/master@{#459734}
Committed:
https://chromium.googlesource.com/chromium/src/+/7166178c862576e32636718ec0ec...
==========

[commit-bot: I haz the power, 2017-03-27 09:40:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7166178c862576e32636718ec0ec...