Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2768263005: Fix PointerLockBrowserTest on Mac. (Closed)

Created:
3 years, 9 months ago by lfg
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PointerLockBrowserTest on Mac. The RenderWidgetHostViewMac can outlive its RenderWidgetHost, so we need to check if the RenderWidgetHost is alive before dereferencing it. BUG=none Review-Url: https://codereview.chromium.org/2768263005 Cr-Commit-Position: refs/heads/master@{#459428} Committed: https://chromium.googlesource.com/chromium/src/+/de6f0d1f3eb6f136533d62cb107c36223374ee3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M content/browser/pointer_lock_browsertest.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/pointer_lock_browsertest_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lfg
Avi, please take a look.
3 years, 9 months ago (2017-03-24 13:52:42 UTC) #4
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-24 15:19:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768263005/1
3 years, 9 months ago (2017-03-24 15:25:19 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 15:30:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de6f0d1f3eb6f136533d62cb107c...

Powered by Google App Engine
This is Rietveld 408576698