[MD settings] update content settings when incognito changes

[MD settings] update content settings when incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2768243002
Cr-Commit-Position: refs/heads/master@{#459304}
Committed: https://chromium.googlesource.com/chromium/src/+/2f3d26477b0cf74265f99dd09c9f48fa33b73850

[dschuyler, 2017-03-23 01:25:28]

Description was changed from

==========
[MD settings] update content settings with incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
==========

to

==========
[MD settings] update content settings with incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-23 01:25:31]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 01:26:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-23 01:26:19]

Description was changed from

==========
[MD settings] update content settings with incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update content settings when incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-03-23 01:26:19]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:31:17]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-23 18:19:47]

Should we be adding/updating a test at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/site_lis...
It already has some setup for incognito only exceptions.

https://codereview.chromium.org/2768243002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2768243002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.js:147: * @param
{boolean} incognitoEnabled Unused.
Can we omit the parameter since it is not used?

[dschuyler, 2017-03-23 21:08:02]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 21:09:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-03-23 21:09:06]

Unit test in https://codereview.chromium.org/2769863006/

https://codereview.chromium.org/2768243002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2768243002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_list.js:147: * @param
{boolean} incognitoEnabled Unused.
On 2017/03/23 18:19:46, dpapad wrote:
> Can we omit the parameter since it is not used?

Done.

[dpapad, 2017-03-23 21:51:56]

LGTM.

[commit-bot: I haz the power, 2017-03-23 22:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:57:09]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dschuyler, 2017-03-24 00:32:24]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:33:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:41:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490315544352920,
"parent_rev": "f999b52898f398f61dcf69efb9ff96ed4fcff1cc", "commit_rev":
"2f3d26477b0cf74265f99dd09c9f48fa33b73850"}

[commit-bot: I haz the power, 2017-03-24 00:41:55]

Description was changed from

==========
[MD settings] update content settings when incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] update content settings when incognito changes

This CL updates the site list data when incognito becomes active or when
it deactivates. E.g. when the first incognito window is created.

BUG=680619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2768243002
Cr-Commit-Position: refs/heads/master@{#459304}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f3d26477b0cf74265f99dd09c9f...
==========

[commit-bot: I haz the power, 2017-03-24 00:41:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f3d26477b0cf74265f99dd09c9f...