Milo: Fix Gerrit CL reporting in buildbucket view

milo/appengine/buildbucket/common.go

Index: milo/appengine/buildbucket/common.go
diff --git a/milo/appengine/buildbucket/common.go b/milo/appengine/buildbucket/common.go
index a9a4f90b6399548e3cff53b7915ca9f13535bba5..40b4dab7dc49bdc6e7ffdcaf064ef0e9208645e6 100644
--- a/milo/appengine/buildbucket/common.go
+++ b/milo/appengine/buildbucket/common.go
@@ -122,13 +122,11 @@ func getChangeList(build *buildbucket.ApiBuildMessage, params *buildParameters,
 		}
 
 	case "gerrit":
-		if prop.GerritURL != "" && prop.GerritChangeNumber != 0 {
+		if prop.PatchGerritURL != "" && prop.PatchIssue != 0 {
 			result = &resp.Commit{
-				Revision:        prop.GerritPatchRef,
-				RequestRevision: prop.GerritPatchRef,
 				Changelist: &resp.Link{
-					Label: fmt.Sprintf("Gerrit CL %d", prop.GerritChangeNumber),
-					URL:   prop.GerritChangeURL,
+					Label: fmt.Sprintf("Gerrit CL %d", prop.PatchIssue),
+					URL:   fmt.Sprintf("%s/c/%d", prop.PatchGerritURL, prop.PatchIssue),

[tandrii(chromium), 2017/03/23 15:32:57]

wdyt about linking to specific patchset like you do in Rietveld's case.
In gerrit properties, it's called 'patch_set' (because I wanted to keep 'patch_'
prefix for all props set by CQ.

[nodir, 2017/03/24 06:35:02]

+1

do it if GerritPatchSet != 0

[hinoka, 2017/03/27 18:22:08]

Done.

 				},
 			}
 		}