Milo: Fix Gerrit CL reporting in buildbucket view

milo/appengine/buildbucket/common.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbucket
 
 import (
         "fmt"
         "net/http"
         "strings"
@@ skipping 104 matching lines @@
                                 Revision:        resultDetails.Properties.GotRevision,
                                 RequestRevision: prop.Revision,
                                 Changelist: &resp.Link{
                                         Label: fmt.Sprintf("Rietveld CL %d", prop.Issue),
                                         URL:   fmt.Sprintf("%s/%d/#ps%d", prop.RietveldURL, prop.Issue, prop.PatchSet),
                                 },
                         }
                 }
 
         case "gerrit":
-                if prop.GerritURL != "" && prop.GerritChangeNumber != 0 {
+                if prop.PatchGerritURL != "" && prop.PatchIssue != 0 {
                         result = &resp.Commit{
-                                Revision:        prop.GerritPatchRef,
-                                RequestRevision: prop.GerritPatchRef,
                                 Changelist: &resp.Link{
-                                        Label: fmt.Sprintf("Gerrit CL %d", prop.GerritChangeNumber),
-                                        URL:   prop.GerritChangeURL,
+                                        Label: fmt.Sprintf("Gerrit CL %d", prop.PatchIssue),
+                                        URL:   fmt.Sprintf("%s/c/%d", prop.PatchGerritURL, prop.PatchIssue),

[tandrii(chromium), 2017/03/23 15:32:57]

wdyt about linking to specific patchset like you do in Rietveld's case.
In gerrit properties, it's called 'patch_set' (because I wanted to keep 'patch_'
prefix for all props set by CQ.

[nodir, 2017/03/24 06:35:02]

+1

do it if GerritPatchSet != 0

[hinoka, 2017/03/27 18:22:08]

Done.

                                 },
                         }
                 }
         }
 
         if result != nil && len(params.Changes) != 0 {
                 // tryjobs have one change and it is the CL author
                 result.AuthorEmail = params.Changes[0].Author.Email
         }
 
         return result
 }