Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2768193002: [DevTools] Adjust popover arrow position. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Adjust popover arrow position. It's now properly centered on color swatches, and has enough margin from the anchor box. BUG=704086 Review-Url: https://codereview.chromium.org/2768193002 Cr-Commit-Position: refs/heads/master@{#459010} Committed: https://chromium.googlesource.com/chromium/src/+/1ccd33f53b1c52f9afc2df087a0f608c13bc6bb5

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/glassPane.css View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dgozman
Could you please take a look?
3 years, 9 months ago (2017-03-22 23:44:37 UTC) #2
lushnikov
lgtm
3 years, 9 months ago (2017-03-23 00:18:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768193002/20001
3 years, 9 months ago (2017-03-23 00:46:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/412852)
3 years, 9 months ago (2017-03-23 01:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768193002/20001
3 years, 9 months ago (2017-03-23 05:23:23 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 06:31:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1ccd33f53b1c52f9afc2df087a0f...

Powered by Google App Engine
This is Rietveld 408576698