Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2768093006: [Payments] Desktop: Error message in the dialog. (Closed)

Created:
3 years, 9 months ago by Mathieu
Modified:
3 years, 8 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews, darin-cc_chromium.org, gogerald+paymentswatch_chromium.org, jam, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Desktop: Error message in the dialog. Surfaced when the website calls "complete" in a failure scenario. BUG=706053 TEST=browser_tests Review-Url: https://codereview.chromium.org/2768093006 Cr-Commit-Position: refs/heads/master@{#460390} Committed: https://chromium.googlesource.com/chromium/src/+/21879589342d3991449a8f6eef8ef40802a61d5d

Patch Set 1 : Initial #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -45 lines) Patch
M chrome/browser/payments/chrome_payment_request_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/payments/chrome_payment_request_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/payments/error_message_view_controller.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/payments/error_message_view_controller.cc View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view.cc View 3 chunks +21 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 2 chunks +1 line, -22 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/payments/content/payment_request.cc View 1 chunk +8 lines, -6 lines 0 comments Download
M components/payments/content/payment_request_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/payments/content/payment_request_dialog.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/payments_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mathieu
Anthony PTAL?
3 years, 8 months ago (2017-03-28 18:01:48 UTC) #5
Mathieu
On 2017/03/28 18:01:48, Mathieu wrote: > Anthony PTAL? Friendly ping!
3 years, 8 months ago (2017-03-29 13:24:57 UTC) #6
anthonyvd
lgtm
3 years, 8 months ago (2017-03-29 14:11:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768093006/60001
3 years, 8 months ago (2017-03-29 14:12:27 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 15:16:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/21879589342d3991449a8f6eef8e...

Powered by Google App Engine
This is Rietveld 408576698