Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/chrome_setting.cc ('k') | extensions/renderer/event_emitter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index 4dcf0389e2b7fd0f8d7a1ccc456b58670f6267d1..72df5e05987380ccfa1dbef90a24b7a6e0f91d63 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -206,14 +206,34 @@ void SendRequestIPC(ScriptContext* context,
// background pages.
void SendEventListenersIPC(binding::EventListenersChanged changed,
ScriptContext* context,
- const std::string& event_name) {
- if (changed == binding::EventListenersChanged::HAS_LISTENERS) {
- content::RenderThread::Get()->Send(new ExtensionHostMsg_AddListener(
- context->GetExtensionID(), context->url(), event_name));
+ const std::string& event_name,
+ const base::DictionaryValue* filter) {
+ // TODO(devlin): Fix this. We need to account for lazy listeners, but it
+ // also depends on if the listener is removed due to the context being torn
+ // down or the extension unregistering.
+ bool lazy = false;
+ std::string extension_id = context->GetExtensionID();
+
+ if (filter) {
+ if (changed == binding::EventListenersChanged::HAS_LISTENERS) {
+ content::RenderThread::Get()->Send(
+ new ExtensionHostMsg_AddFilteredListener(extension_id, event_name,
+ *filter, lazy));
+ } else {
+ DCHECK_EQ(binding::EventListenersChanged::NO_LISTENERS, changed);
+ content::RenderThread::Get()->Send(
+ new ExtensionHostMsg_RemoveFilteredListener(extension_id, event_name,
+ *filter, lazy));
+ }
} else {
- DCHECK_EQ(binding::EventListenersChanged::NO_LISTENERS, changed);
- content::RenderThread::Get()->Send(new ExtensionHostMsg_RemoveListener(
- context->GetExtensionID(), context->url(), event_name));
+ if (changed == binding::EventListenersChanged::HAS_LISTENERS) {
+ content::RenderThread::Get()->Send(new ExtensionHostMsg_AddListener(
+ context->GetExtensionID(), context->url(), event_name));
+ } else {
+ DCHECK_EQ(binding::EventListenersChanged::NO_LISTENERS, changed);
+ content::RenderThread::Get()->Send(new ExtensionHostMsg_RemoveListener(
+ context->GetExtensionID(), context->url(), event_name));
+ }
}
}
« no previous file with comments | « extensions/renderer/chrome_setting.cc ('k') | extensions/renderer/event_emitter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698