Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1598)

Unified Diff: extensions/renderer/chrome_setting.cc

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_event_listeners_unittest.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/chrome_setting.cc
diff --git a/extensions/renderer/chrome_setting.cc b/extensions/renderer/chrome_setting.cc
index 13f5c2042d377d6903a7e2fdaadf1e020dcbf976..b883042902153159e581f0e3877c5e1b22acaa69 100644
--- a/extensions/renderer/chrome_setting.cc
+++ b/extensions/renderer/chrome_setting.cc
@@ -143,10 +143,11 @@ v8::Local<v8::Value> ChromeSetting::GetOnChangeEvent(
DCHECK(!event.IsEmpty());
if (event->IsUndefined()) {
+ bool supports_filters = false;
event = event_handler_->CreateEventInstance(
base::StringPrintf("types.ChromeSetting.%s.onChange",
pref_name_.c_str()),
- context);
+ supports_filters, context);
v8::Maybe<bool> set_result = wrapper->SetPrivate(context, key, event);
if (!set_result.IsJust() || !set_result.FromJust()) {
NOTREACHED();
« no previous file with comments | « extensions/renderer/api_event_listeners_unittest.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698