Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: extensions/renderer/api_binding_js_util.h

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding.cc ('k') | extensions/renderer/api_binding_js_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_js_util.h
diff --git a/extensions/renderer/api_binding_js_util.h b/extensions/renderer/api_binding_js_util.h
index 00198069dccb2ad3930a32f3d99d6c228e630e57..a02b07e33adf4ef093b32022cf970b99e46dd0ab 100644
--- a/extensions/renderer/api_binding_js_util.h
+++ b/extensions/renderer/api_binding_js_util.h
@@ -51,12 +51,14 @@ class APIBindingJSUtil final : public gin::Wrappable<APIBindingJSUtil> {
// A handler to allow custom bindings to create custom extension API event
// objects (e.g. foo.onBar).
- // TODO(devlin): Currently, we ignore schema and options. We'll need to take
- // at least options into account.
+ // Note: The JS version allows for constructing declarative events; it's
+ // unclear if we'll need to support this.
+ // TODO(devlin): Currently, we ignore schema. We may want to take it into
+ // account.
void CreateCustomEvent(gin::Arguments* arguments,
v8::Local<v8::Value> v8_event_name,
v8::Local<v8::Value> unused_schema,
- v8::Local<v8::Value> unused_event_options);
+ bool supports_filters);
// Invalidates an event, removing its listeners and preventing any more from
// being added.
« no previous file with comments | « extensions/renderer/api_binding.cc ('k') | extensions/renderer/api_binding_js_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698