Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: extensions/renderer/api_binding_js_util.cc

Issue 2768093002: [Reland][Extensions Bindings] Add support for filtered events (Closed)
Patch Set: Fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/api_binding_js_util.h ('k') | extensions/renderer/api_binding_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api_binding_js_util.cc
diff --git a/extensions/renderer/api_binding_js_util.cc b/extensions/renderer/api_binding_js_util.cc
index d554bb54d1006e7e65d8d89e8f3b2e741cfbc491..84b596633a96f228138e483200712a74e71c5a03 100644
--- a/extensions/renderer/api_binding_js_util.cc
+++ b/extensions/renderer/api_binding_js_util.cc
@@ -75,11 +75,10 @@ void APIBindingJSUtil::RegisterEventArgumentMassager(
event_handler_->RegisterArgumentMassager(context, event_name, massager);
}
-void APIBindingJSUtil::CreateCustomEvent(
- gin::Arguments* arguments,
- v8::Local<v8::Value> v8_event_name,
- v8::Local<v8::Value> unused_schema,
- v8::Local<v8::Value> unused_event_options) {
+void APIBindingJSUtil::CreateCustomEvent(gin::Arguments* arguments,
+ v8::Local<v8::Value> v8_event_name,
+ v8::Local<v8::Value> unused_schema,
+ bool supports_filters) {
v8::Isolate* isolate = arguments->isolate();
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Object> holder;
@@ -95,11 +94,16 @@ void APIBindingJSUtil::CreateCustomEvent(
event_name = gin::V8ToString(v8_event_name);
}
+ DCHECK(!supports_filters || !event_name.empty())
+ << "Events that support filters cannot be anonymous.";
+
v8::Local<v8::Value> event;
- if (event_name.empty())
+ if (event_name.empty()) {
event = event_handler_->CreateAnonymousEventInstance(context);
- else
- event = event_handler_->CreateEventInstance(event_name, context);
+ } else {
+ event = event_handler_->CreateEventInstance(event_name, supports_filters,
+ context);
+ }
arguments->Return(event);
}
« no previous file with comments | « extensions/renderer/api_binding_js_util.h ('k') | extensions/renderer/api_binding_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698