Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2768073004: Revert of Fixed external wpt csp img-src/* tests. (Closed)

Created:
3 years, 9 months ago by Mike Wittman
Modified:
3 years, 9 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed external wpt csp img-src/* tests. (patchset #3 id:40001 of https://codereview.chromium.org/2763253002/ ) Reason for revert: Flaking on several Chrome builds. For example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7/builds/51197 08:08:14.766 2480 worker/4 external/wpt/content-security-policy/img-src/img-src-4_1.sub.html output stderr lines: 08:08:14.766 2480 CONSOLE ERROR: Refused to load the image 'http://www1.web-platform.test/content-security-policy/support/fail.png' because it violates the following Content Security Policy directive: "img-src 'self' www.web-platform.test:8001". 08:08:14.766 2480 08:08:14.780 2796 [18526/52077] external/wpt/content-security-policy/img-src/img-src-4_1.sub.html failed unexpectedly (asserts failed) 08:08:14.778 2480 worker/4 external/wpt/content-security-policy/img-src/img-src-4_1.sub.html failed: 08:08:14.778 2480 worker/4 asserts failed Original issue's description: > Fixed external wpt csp img-src/* tests. > > Fixed the existing test > Moved over some tests from http/test/security/contentSecurityPolicy > Un-skipped the img-src folder > > BUG=694525 > > Review-Url: https://codereview.chromium.org/2763253002 > Cr-Commit-Position: refs/heads/master@{#459053} > Committed: https://chromium.googlesource.com/chromium/src/+/a124c835aadb7c241e5b2bf8c06d758bef4b93fd TBR=mkwst@chromium.org,qyearsley@chromium.org,andypaicu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694525 Review-Url: https://codereview.chromium.org/2768073004 Cr-Commit-Position: refs/heads/master@{#459158} Committed: https://chromium.googlesource.com/chromium/src/+/e0885fe729e75e0e692247e482907318b8960c42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -162 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.html.sub.headers View 1 chunk +6 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.sub.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-full-host-wildcard-blocked.sub.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-host-partial-wildcard-allowed.sub.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-none-blocks.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-port-wildcard-allowed.sub.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-wildcard-allowed.html View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-allowed.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-allowed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked.html View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-alt-content.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-full-host-wildcard-fails.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-full-host-wildcard-fails-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Mike Wittman
Created Revert of Fixed external wpt csp img-src/* tests.
3 years, 9 months ago (2017-03-23 18:39:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2768073004/1
3 years, 9 months ago (2017-03-23 18:40:25 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 18:42:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0885fe729e75e0e692247e48290...

Powered by Google App Engine
This is Rietveld 408576698