Remove redundant checks from third_party/WebKit/PRESUBMIT.py.

Remove redundant checks from third_party/WebKit/PRESUBMIT.py.

Redudant checks removed in this CL:
    _CheckForVersionControlConflicts
    _CheckPatchFiles
    _CheckFilePermissions

These checks are already in _CommonChecks in the top-level PRESUBMIT.py,
and they apply in third_party/WebKit from that already.
(https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=2093)

Note that third_party/WebKit is in an _EXCLUDED_PATHS global in that
file, but it's not excluded from these checks in the top-level presubmit
since that global isn't taken into consideration for these checks.

BUG=649970
Review-Url: https://codereview.chromium.org/2768073003
Cr-Commit-Position: refs/heads/master@{#459270}
Committed: https://chromium.googlesource.com/chromium/src/+/5e1457c6a247571aa25c76364693863b7bdd4b7f

[qyearsley, 2017-03-23 00:19:25]

qyearsley@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-03-23 12:55:59]

lgtm, excellent CL description, thanks!

You mention in https://codereview.chromium.org/2375713002/#msg12 that we'd want
to keep blink in _EXCLUDED_PATHS -- I think that isn't true medium-term. It
might not even be true now (now that all the code is reformatted and whatnot –
but we might need the member function renaming work to complete first too).

(Also, that global PRESUBMIT file is kind of sad to look at – over 2300 lines,
several references to gyp, _CheckForWindowsLineEndings checks gyp and gypi and
gn but not gni, etc – in case you feel like cleaning up more PRESUBMIT stuff :-)
)

https://codereview.chromium.org/2768073003/diff/1/third_party/WebKit/PRESUBMI...
File third_party/WebKit/PRESUBMIT.py (left):

https://codereview.chromium.org/2768073003/diff/1/third_party/WebKit/PRESUBMI...
third_party/WebKit/PRESUBMIT.py:118: "Don't commit .rej and .orig files.",
problems)]
This feels like a remnant from svn days anyhow – we might want to remove this
from the global PRESUBMIT too (?)

[qyearsley, 2017-03-23 18:17:04]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:18:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-03-23 18:20:19]

On 2017/03/23 at 12:55:59, thakis wrote:
> lgtm, excellent CL description, thanks!
> 
> You mention in https://codereview.chromium.org/2375713002/#msg12 that we'd
want to keep blink in _EXCLUDED_PATHS -- I think that isn't true medium-term. It
might not even be true now (now that all the code is reformatted and whatnot –
but we might need the member function renaming work to complete first too).

Yep, I think the next major step here is to remove PanProjectChecks from the
Blink presubmit, and remove Blink from _EXCLUDED_PATHS. This might be possible
now but might have to wait?

> (Also, that global PRESUBMIT file is kind of sad to look at – over 2300 lines,
several references to gyp, _CheckForWindowsLineEndings checks gyp and gypi and
gn but not gni, etc – in case you feel like cleaning up more PRESUBMIT stuff :-)
)

Hmm, sounds like it may be a good idea to file some issues for this.

>
https://codereview.chromium.org/2768073003/diff/1/third_party/WebKit/PRESUBMI...
> File third_party/WebKit/PRESUBMIT.py (left):
> 
>
https://codereview.chromium.org/2768073003/diff/1/third_party/WebKit/PRESUBMI...
> third_party/WebKit/PRESUBMIT.py:118: "Don't commit .rej and .orig files.",
problems)]
> This feels like a remnant from svn days anyhow – we might want to remove this
from the global PRESUBMIT too (?)

Possibly -- I'm not sure what .rej and .orig files are from, but it sounds like
that might be created by `patch`, and maybe it's theoretically possible that
somebody might accidentally create them somehow even after we've switched from
SVN?

[commit-bot: I haz the power, 2017-03-23 18:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:36:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2017-03-23 23:08:23]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-03-23 23:09:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 23:14:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490310503483030, "parent_rev":
"9df2cccc337ca57188f9709b2205439347870606", "commit_rev":
"5e1457c6a247571aa25c76364693863b7bdd4b7f"}

[commit-bot: I haz the power, 2017-03-23 23:15:27]

Description was changed from

==========
Remove redundant checks from third_party/WebKit/PRESUBMIT.py.

Redudant checks removed in this CL:
    _CheckForVersionControlConflicts
    _CheckPatchFiles
    _CheckFilePermissions

These checks are already in _CommonChecks in the top-level PRESUBMIT.py,
and they apply in third_party/WebKit from that already.
(https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=2093)

Note that third_party/WebKit is in an _EXCLUDED_PATHS global in that
file, but it's not excluded from these checks in the top-level presubmit
since that global isn't taken into consideration for these checks.

BUG=649970
==========

to

==========
Remove redundant checks from third_party/WebKit/PRESUBMIT.py.

Redudant checks removed in this CL:
    _CheckForVersionControlConflicts
    _CheckPatchFiles
    _CheckFilePermissions

These checks are already in _CommonChecks in the top-level PRESUBMIT.py,
and they apply in third_party/WebKit from that already.
(https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=2093)

Note that third_party/WebKit is in an _EXCLUDED_PATHS global in that
file, but it's not excluded from these checks in the top-level presubmit
since that global isn't taken into consideration for these checks.

BUG=649970

Review-Url: https://codereview.chromium.org/2768073003
Cr-Commit-Position: refs/heads/master@{#459270}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e1457c6a247571aa25c76364693...
==========

[commit-bot: I haz the power, 2017-03-23 23:15:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e1457c6a247571aa25c76364693...