Format all multitests

Format all multitests

BUG=
R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/312b66dd5f9dd1cb5f376aed4ed3072aa6d5d5a6

[Jacob, 2017-03-22 20:12:23]

jacobr@google.com changed reviewers:
+ rnystrom@google.com

[Jacob, 2017-03-22 20:12:26]

This was generated by

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/^(\s*)(.+)(
\/\/#)/\/\/bW9a2S5JZs8Mz5rPemKC$1$2$3/'

 git diff origin/master --raw | grep " [AM]" | awk '{print $6}' | grep ".dart$"
| xargs dartfmt -w

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e
's/^\s*\/\/bW9a2S5JZs8Mz5rPemKC$1$2$3//'

[Jacob, 2017-03-22 21:18:57]

Description was changed from

==========
Format all multitests

BUG=
==========

to

==========
Format all multitests

BUG=
==========

[Bob Nystrom, 2017-03-22 23:46:40]

LGTM.

https://codereview.chromium.org/2768073002/diff/1/tests/corelib/list_test.dart
File tests/corelib/list_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib/list_test.dar...
tests/corelib/list_test.dart:627: }); // Not null.
These would be more readable now with the comments above each Expect call
instead of at the end.

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/big_in...
File tests/corelib_strong/big_integer_arith_vm_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/big_in...
tests/corelib_strong/big_integer_arith_vm_test.dart:312: ;
You can remove these extra ";".

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/list_t...
File tests/corelib_strong/list_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/list_t...
tests/corelib_strong/list_test.dart:627: }); // Not null.
Same here about moving the comments.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
File tests/language/compile_time_constant_k_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:8: 'a': 3, // //# 01: static
type warning
You could fix the indentation here if you want.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:16: '__proto__': 498, // //#
03: continued
Ditto.

https://codereview.chromium.org/2768073002/diff/1/tests/language/constant_typ...
File tests/language/constant_type_literal_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/constant_typ...
tests/language/constant_type_literal_test.dart:10: T //# 01: compile-time error
Maybe fix the indentation?

https://codereview.chromium.org/2768073002/diff/1/tests/language/constructor_...
File tests/language/constructor_redirect_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/constructor_...
tests/language/constructor_redirect_test.dart:23: int staticFun(int v1, int v2)
{
Is this an artifact of your script? If not, it looks like a formatter bug.

https://codereview.chromium.org/2768073002/diff/1/tests/language/map_literal3...
File tests/language/map_literal3_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/map_literal3...
tests/language/map_literal3_test.dart:111: num>{"pink": 100};
Oh, dang. The latest version of dartfmt (1.0.0) fixes this. :-/

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
File tests/lib/mirrors/globalized_closures2_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
tests/lib/mirrors/globalized_closures2_test.dart:36: ;
Remove the semicolon.

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
File tests/lib/mirrors/globalized_closures_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
tests/lib/mirrors/globalized_closures_test.dart:35: ;
Ditto.

[Jacob, 2017-03-23 17:26:49]

Description was changed from

==========
Format all multitests

BUG=
==========

to

==========
Format all multitests

BUG=
R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/312b66dd5f9dd1cb5f376aed4ed3072aa6d5d5a6
==========

[Jacob, 2017-03-23 17:26:51]

Committed patchset #1 (id:1) manually as
312b66dd5f9dd1cb5f376aed4ed3072aa6d5d5a6.

[Jacob, 2017-03-23 17:27:33]

https://codereview.chromium.org/2768073002/diff/1/tests/corelib/list_test.dart
File tests/corelib/list_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib/list_test.dar...
tests/corelib/list_test.dart:627: }); // Not null.
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> These would be more readable now with the comments above each Expect call
> instead of at the end.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/big_in...
File tests/corelib_strong/big_integer_arith_vm_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/big_in...
tests/corelib_strong/big_integer_arith_vm_test.dart:312: ;
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> You can remove these extra ";".

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/list_t...
File tests/corelib_strong/list_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/corelib_strong/list_t...
tests/corelib_strong/list_test.dart:627: }); // Not null.
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> Same here about moving the comments.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
File tests/language/compile_time_constant_k_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:8: 'a': 3, // //# 01: static
type warning
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> You could fix the indentation here if you want.

thanks for spotting. done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:8: 'a': 3, // //# 01: static
type warning
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> You could fix the indentation here if you want.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:16: '__proto__': 498, // //#
03: continued
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/compile_time...
tests/language/compile_time_constant_k_test.dart:16: '__proto__': 498, // //#
03: continued
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/constant_typ...
File tests/language/constant_type_literal_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/constant_typ...
tests/language/constant_type_literal_test.dart:10: T //# 01: compile-time error
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> Maybe fix the indentation?

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/language/constructor_...
File tests/language/constructor_redirect_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/constructor_...
tests/language/constructor_redirect_test.dart:23: int staticFun(int v1, int v2)
{
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> Is this an artifact of your script? If not, it looks like a formatter bug.

this is how the formatter formats
static
// some comment
int someFunction(int v1, int v2).
Reverted this file.

This line violates the expectation that the multitest line is a valid statement.

https://codereview.chromium.org/2768073002/diff/1/tests/language/constructor_...
tests/language/constructor_redirect_test.dart:23: int staticFun(int v1, int v2)
{
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> Is this an artifact of your script? If not, it looks like a formatter bug.
Actually this is plausibly the correct format for this multitest as it makes it
less surprising.
On one hand this new formatting while strange is actually consistent with the
behavior interpreting this as a multitest.
when the // # 01: line is removed the program is
  static
      int staticFun(int v1, int v2) {
    return v1
  }


so the 
int staticFun 
line should be indented.

https://codereview.chromium.org/2768073002/diff/1/tests/language/map_literal3...
File tests/language/map_literal3_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/language/map_literal3...
tests/language/map_literal3_test.dart:111: num>{"pink": 100};
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> Oh, dang. The latest version of dartfmt (1.0.0) fixes this. :-/

It should be reasonable to just rerun the safe format scripts on the code base
each major format release fixing the small number of deltas.

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
File tests/lib/mirrors/globalized_closures2_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
tests/lib/mirrors/globalized_closures2_test.dart:36: ;
On 2017/03/22 23:46:39, Bob Nystrom wrote:
> Remove the semicolon.

Done.

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
File tests/lib/mirrors/globalized_closures_test.dart (right):

https://codereview.chromium.org/2768073002/diff/1/tests/lib/mirrors/globalize...
tests/lib/mirrors/globalized_closures_test.dart:35: ;
On 2017/03/22 23:46:40, Bob Nystrom wrote:
> Ditto.

Done.