Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748
Review-Url: https://codereview.chromium.org/2768053003
Cr-Commit-Position: refs/heads/master@{#459650}
Committed: https://chromium.googlesource.com/chromium/src/+/a9461a0586471e6fa16c02201f69eb366acc8350

[emilio, 2017-03-23 19:00:19]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 19:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:40:19]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[emilio, 2017-03-23 21:39:19]

Description was changed from

==========
[wip] Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

I believe we might need to special-case FirstLine to make everything work
though.

BUG=657748
==========

to

==========
Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748
==========

[emilio, 2017-03-23 21:39:49]

Description was changed from

==========
Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748
==========

to

==========
Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748
==========

[emilio, 2017-03-23 21:41:22]

ecobos@igalia.com changed reviewers:
+ rune@opera.com

[emilio, 2017-03-23 21:41:22]

Hi rune,

Actually I expected this one to be a bit trickier, but try is green doing the
obvious, so if you could sign-off this, it'd be appreciated.

Thanks in advance.

[rune, 2017-03-23 22:57:47]

https://codereview.chromium.org/2768053003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (left):

https://codereview.chromium.org/2768053003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3101:
!style()->hasPseudoStyle(pseudoStyleRequest.pseudoId))
I'm not sure I understand this code, but it looks like we pass in ownStyle for
::first-line only, and that we always early out here for other pseudos based on
ownStyle telling us this is not ::first-line and the fact that hasPseudoStyle
needs to return true for us to have a pseudo element.

What I'm wondering is if we by removing !ownStyle early out incorrectly if
hasPseudoStyle() is false, but we still need to create a pseudo style.

Can you explain why the !ownStyle was there and why removing it won't change the
behavior?

[emilio, 2017-03-23 23:33:13]

On 2017/03/23 22:57:47, rune wrote:
>
https://codereview.chromium.org/2768053003/diff/1/third_party/WebKit/Source/c...

> What I'm wondering is if we by removing !ownStyle early out incorrectly if
> hasPseudoStyle() is false, but we still need to create a pseudo style.
> 
> Can you explain why the !ownStyle was there and why removing it won't change
the
> behavior?

I can't explain why the !ownStyle was there, and I didn't understand why that
code was that way either, so... I did some code archeology and the first commit
that introduced that check is
https://chromium.googlesource.com/chromium/src/+/4aa328a392d41459fd4559cdb076....

It seems that it's trying to avoid using a stale cached style. The reviews at
https://bugs.webkit.org/show_bug.cgi?id=26963 doesn't seem to be really helpful
either.

That is, curiously, the revision where Element::pseudoStyleCacheIsInvalid is
introduced :). I think the check is no longer relevant, and is only a source of
complexity, but I haven't been around for all these years in order to know what
has changed (I could keep doing some more archeology though).

The crash that patch was fixing definitely not crashes now :)

[rune, 2017-03-24 15:12:53]

lgtm

[emilio, 2017-03-24 18:40:58]

The CQ bit was checked by ecobos@igalia.com

[commit-bot: I haz the power, 2017-03-24 18:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 20:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 20:48:55]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[emilio, 2017-03-25 11:29:45]

The CQ bit was checked by ecobos@igalia.com

[commit-bot: I haz the power, 2017-03-25 11:29:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 13:29:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490441385587150, "parent_rev":
"f57d8c59f68a3216a13a1e77bc5467d2fc0192c0", "commit_rev":
"a9461a0586471e6fa16c02201f69eb366acc8350"}

[commit-bot: I haz the power, 2017-03-25 13:30:25]

Description was changed from

==========
Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748
==========

to

==========
Get rid of ownStyle in LayoutObject::getUncachedPseudoStyle.

It's quite useless right now.

BUG=657748

Review-Url: https://codereview.chromium.org/2768053003
Cr-Commit-Position: refs/heads/master@{#459650}
Committed:
https://chromium.googlesource.com/chromium/src/+/a9461a0586471e6fa16c02201f69...
==========

[commit-bot: I haz the power, 2017-03-25 13:30:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9461a0586471e6fa16c02201f69...