Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 276793002: Revert "Support warning decorations in Timeline flame chart based on trace events" (Closed)

Created:
6 years, 7 months ago by ojan
Modified:
6 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert "Support warning decorations in Timeline flame chart based on trace events" Revert "Build fix after r173654" Reverts r173654 and r173655. Broke inspector/tracing-session-id.html. TBR=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173701

Patch Set 1 #

Patch Set 2 : upload correct patch thsi time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -692 lines) Patch
M Source/devtools/devtools.gypi View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +1 line, -1 line 0 comments Download
A + Source/devtools/front_end/sdk/TracingModel.js View 4 chunks +0 lines, -47 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 2 chunks +3 lines, -39 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +0 lines, -1 line 0 comments Download
D Source/devtools/front_end/timeline/TracingModel.js View 1 chunk +0 lines, -601 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 7 months ago (2014-05-09 00:21:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/276793002/20001
6 years, 7 months ago (2014-05-09 00:23:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 00:23:17 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-09 00:23:18 UTC) #4
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 7 months ago (2014-05-09 00:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/276793002/20001
6 years, 7 months ago (2014-05-09 00:35:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 01:46:25 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 02:22:26 UTC) #8
Message was sent while issue was closed.
Change committed as 173701

Powered by Google App Engine
This is Rietveld 408576698