Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 276793002: Revert "Support warning decorations in Timeline flame chart based on trace events" (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: upload correct patch thsi time Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/TracingModel.js ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index ff7cc8487ac584aa25e179db606cdd3a8b2f1784..469add57b9f78df96b8be7a3c58323e7e87b80f1 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -633,42 +633,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
decorateEntry: function(entryIndex, context, text, barX, barY, barWidth, barHeight, offsetToPosition)
{
- if (barWidth < 5)
- return false;
-
- var record = this._records[entryIndex];
- var timelineData = this._timelineData;
-
- var category = WebInspector.TimelineUIUtils.styleForTimelineEvent(record.name).category;
- // Paint text using white color on dark background.
- if (text) {
- context.save();
- context.fillStyle = "white";
- context.shadowColor = "rgba(0, 0, 0, 0.1)";
- context.shadowOffsetX = 1;
- context.shadowOffsetY = 1;
- context.font = this._font;
- context.fillText(text, barX + this.textPadding(), barY + barHeight - this.textBaseline());
- context.restore();
- }
-
- if (this._model.bindings().eventWarning(record)) {
- context.save();
-
- context.rect(barX, barY, barWidth, this.barHeight());
- context.clip();
-
- context.beginPath();
- context.fillStyle = "red";
- context.moveTo(barX + barWidth - 15, barY + 1);
- context.lineTo(barX + barWidth - 1, barY + 1);
- context.lineTo(barX + barWidth - 1, barY + 15);
- context.fill();
-
- context.restore();
- }
-
- return true;
+ return false;
},
/**
@@ -677,11 +642,10 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
forceDecoration: function(entryIndex)
{
- var record = this._records[entryIndex];
- return !!this._model.bindings().eventWarning(record);
+ return false;
},
- /**
+ /**
* @param {number} entryIndex
* @return {?{startTimeOffset: number, endTimeOffset: number}}
*/
« no previous file with comments | « Source/devtools/front_end/sdk/TracingModel.js ('k') | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698