[inspector] added flag for injected-script-source debugging

[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools frontend as regular user code. We need this when working on new features or debugging issues, it's for internal purpose only and doesn't provide any benefits for end users.

Flag: --expose-inspector-scripts

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2767873002
Cr-Commit-Position: refs/heads/master@{#44039}
Committed: https://chromium.googlesource.com/v8/v8/+/5f8c0a139637f4fcdea1eaad0eccd8d97299e526

[kozy, 2017-03-22 07:24:11]

Description was changed from

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend. Sometimes it's useful for debugging issues.

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. Sometimes it's useful for debugging issues.

BUG=none
R=yangguo@chromium.org
==========

[kozy, 2017-03-22 07:24:54]

Description was changed from

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. Sometimes it's useful for debugging issues.

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. Sometimes it's useful for debugging issues.

Flag: --compile_inspector_scripts_as_user

BUG=none
R=yangguo@chromium.org
==========

[kozy, 2017-03-22 07:25:08]

Yang, please take a look!

[kozy, 2017-03-22 07:26:08]

Description was changed from

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. Sometimes it's useful for debugging issues.

Flag: --compile_inspector_scripts_as_user

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. We need this when working on new features or
debugging issues, it's for internal purpose only and doesn't provide any
benefits for end users.

Flag: --compile_inspector_scripts_as_user

BUG=none
R=yangguo@chromium.org
==========

[Yang, 2017-03-22 11:00:01]

lgtm.

https://codereview.chromium.org/2767873002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2767873002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:857: DEFINE_BOOL(compile_inspector_scripts_as_user,
false,
Can we call this expose_inspector_scripts instead?

https://codereview.chromium.org/2767873002/diff/1/test/inspector/debugger/ste...
File test/inspector/debugger/stepping-ignores-injected-script.js (right):

https://codereview.chromium.org/2767873002/diff/1/test/inspector/debugger/ste...
test/inspector/debugger/stepping-ignores-injected-script.js:4: 
Can we also have a test that uses the flag by adding a line to the test "Flags:
--compile_inspector_scripts_as_user"?

[kozy, 2017-03-22 17:08:50]

all done, thanks.

https://codereview.chromium.org/2767873002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2767873002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:857: DEFINE_BOOL(compile_inspector_scripts_as_user,
false,
On 2017/03/22 11:00:01, Yang wrote:
> Can we call this expose_inspector_scripts instead?

Done.

https://codereview.chromium.org/2767873002/diff/1/test/inspector/debugger/ste...
File test/inspector/debugger/stepping-ignores-injected-script.js (right):

https://codereview.chromium.org/2767873002/diff/1/test/inspector/debugger/ste...
test/inspector/debugger/stepping-ignores-injected-script.js:4: 
On 2017/03/22 11:00:01, Yang wrote:
> Can we also have a test that uses the flag by adding a line to the test
"Flags:
> --compile_inspector_scripts_as_user"?

Done.

[kozy, 2017-03-22 17:08:56]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-22 17:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2767873002/#ps40001
(title: "added expectations for test")

[commit-bot: I haz the power, 2017-03-22 17:09:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-03-22 17:11:19]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-03-22 17:14:05]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-22 17:14:05]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2767873002/#ps60001
(title: "a")

[commit-bot: I haz the power, 2017-03-22 17:14:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-03-22 17:14:28]

Description was changed from

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. We need this when working on new features or
debugging issues, it's for internal purpose only and doesn't provide any
benefits for end users.

Flag: --compile_inspector_scripts_as_user

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. We need this when working on new features or
debugging issues, it's for internal purpose only and doesn't provide any
benefits for end users.

Flag: --expose-inspector-scripts

BUG=none
R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2017-03-22 17:36:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490202845250950,
"parent_rev": "66ded52f235668cd0e2054b10149d4da8e97413e", "commit_rev":
"5f8c0a139637f4fcdea1eaad0eccd8d97299e526"}

[commit-bot: I haz the power, 2017-03-22 17:37:03]

Description was changed from

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. We need this when working on new features or
debugging issues, it's for internal purpose only and doesn't provide any
benefits for end users.

Flag: --expose-inspector-scripts

BUG=none
R=yangguo@chromium.org
==========

to

==========
[inspector] added flag for injected-script-source debugging

With flag we can debug injected-script-source in inspector-test or from DevTools
frontend as regular user code. We need this when working on new features or
debugging issues, it's for internal purpose only and doesn't provide any
benefits for end users.

Flag: --expose-inspector-scripts

BUG=none
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2767873002
Cr-Commit-Position: refs/heads/master@{#44039}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f8c0a139637f4fcdea1eaad0eccd8d9729...
==========

[commit-bot: I haz the power, 2017-03-22 17:37:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/5f8c0a139637f4fcdea1eaad0eccd8d9729...