Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2767803002: Adds metric to help assess last_n impact on tab restores. (M58 merge) (Closed)

Created:
3 years, 9 months ago by carlosk
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Adds metric to help assess last_n impact on tab restores. This change adds a new metric to help us assess the impact of last_n on the cases where an existing tab has to have its contents restored. This change only affects Chrome on Android. We track tab restores in Tab and call the appropriate, newly introduced methods in OfflinePageUtils where the reporting actually happens. BUG=688588 Review-Url: https://codereview.chromium.org/2754103003 Cr-Commit-Position: refs/heads/master@{#458530} (cherry picked from commit e9f7809b63666b9c8c558dbde9397b4ce23fe119) Review-Url: https://codereview.chromium.org/2767803002 . Cr-Commit-Position: refs/branch-heads/3029@{#348} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/79e7e4dafbc6b93344e3f71e872baafd80f7ca9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java View 6 chunks +116 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 5 chunks +15 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
carlosk
3 years, 9 months ago (2017-03-21 23:07:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
79e7e4dafbc6b93344e3f71e872baafd80f7ca9e.

Powered by Google App Engine
This is Rietveld 408576698