Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2767793002: Merge LayoutNGInline into LayoutNG runtime enabled feature (Closed)

Created:
3 years, 9 months ago by eae
Modified:
3 years, 9 months ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge LayoutNGInline into LayoutNG runtime enabled feature Merge the LayoutNGInline run-time enabled feature into the base LayoutNG one now that the inline implementation is more stable and further along. R=glebl@chromium.org Review-Url: https://codereview.chromium.org/2767793002 Cr-Commit-Position: refs/heads/master@{#458821} Committed: https://chromium.googlesource.com/chromium/src/+/300b1940b287193610a1d5ca6576a39f0d759a7a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_base_layout_algorithm_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 chunk +1 line, -2 lines 1 comment Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
eae
3 years, 9 months ago (2017-03-21 22:42:49 UTC) #1
Gleb Lanbin
lgtm
3 years, 9 months ago (2017-03-21 23:04:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767793002/1
3 years, 9 months ago (2017-03-21 23:04:28 UTC) #8
cbiesinger1
https://codereview.chromium.org/2767793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right): https://codereview.chromium.org/2767793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc#newcode202 third_party/WebKit/Source/core/layout/ng/ng_block_node.cc:202: return RuntimeEnabledFeatures::layoutNGEnabled() || !HasInlineChildren(); You can now always return ...
3 years, 9 months ago (2017-03-21 23:07:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/344823)
3 years, 9 months ago (2017-03-21 23:14:12 UTC) #12
eae
On 2017/03/21 23:07:11, cbiesinger1 wrote: > https://codereview.chromium.org/2767793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc > File third_party/WebKit/Source/core/layout/ng/ng_block_node.cc (right): > > https://codereview.chromium.org/2767793002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc#newcode202 > ...
3 years, 9 months ago (2017-03-21 23:20:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767793002/1
3 years, 9 months ago (2017-03-22 17:06:00 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/64217)
3 years, 9 months ago (2017-03-22 17:32:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767793002/1
3 years, 9 months ago (2017-03-22 18:40:48 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 18:55:47 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/300b1940b287193610a1d5ca6576...

Powered by Google App Engine
This is Rietveld 408576698