Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2767763002: Fix the conditions when fullscreen detector listeners are registered (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the conditions when fullscreen detector listeners are registered Previously, we rely on the DOMNode[Inserted/Removed]IntoDocument events to attach/detach the detector. However this won't work if the video element is created from the parsing process. This CL fixes the issue by overriding insertedInto() and removedFrom() callbacks, which always works regardless of how the video element is inserted into the document. BUG=703210 Review-Url: https://codereview.chromium.org/2758233003 Cr-Commit-Position: refs/heads/master@{#458147} (cherry picked from commit d9d39e2308b617bad51c86f9703828a2fbef95d8) Review-Url: https://codereview.chromium.org/2767763002 . Cr-Commit-Position: refs/branch-heads/3029@{#343} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -43 lines) Patch
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp View 4 chunks +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp View 3 chunks +69 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhiqiang Zhang (Slow)
3 years, 9 months ago (2017-03-21 21:16:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ac66c6ce3966669bb2f3db5bd7a454a96ff4c0c.

Powered by Google App Engine
This is Rietveld 408576698