Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2767743003: Pref service: Merge connectors and send a PrefRegistry in Connect(). (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pref service: Merge connectors and send a PrefRegistry in Connect(). BUG=654988

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -317 lines) Patch
M chrome/browser/prefs/profile_pref_store_manager.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M services/preferences/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/preferences/persistent_pref_store_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M services/preferences/persistent_pref_store_factory.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.h View 1 2 chunks +14 lines, -8 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.cc View 1 7 chunks +38 lines, -34 lines 0 comments Download
M services/preferences/persistent_pref_store_impl_unittest.cc View 14 chunks +91 lines, -141 lines 0 comments Download
M services/preferences/pref_store_manager_impl.h View 5 chunks +11 lines, -16 lines 0 comments Download
M services/preferences/pref_store_manager_impl.cc View 1 9 chunks +72 lines, -40 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.h View 3 chunks +12 lines, -8 lines 0 comments Download
M services/preferences/public/cpp/persistent_pref_store_client.cc View 3 chunks +52 lines, -21 lines 0 comments Download
M services/preferences/public/cpp/preferences.typemap View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/preferences_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/tests/pref_store_client_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 1 2 3 chunks +35 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 2746023002 Patch 320001

Messages

Total messages: 8 (8 generated)
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-22 06:06:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767743003/1
3 years, 9 months ago (2017-03-22 06:07:01 UTC) #2
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-22 06:20:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767743003/20001
3 years, 9 months ago (2017-03-22 06:20:58 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-22 06:53:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2767743003/40001
3 years, 9 months ago (2017-03-22 06:54:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-22 08:28:15 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 08:28:16 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698