Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 2767673002: WPTServe: Run .any.js and .worker.js variations (Closed)

Created:
3 years, 9 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
qyearsley, jeffcarp
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, tkent
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WPTServe: Run .any.js and .worker.js variations When .any.js and .worker.js files are seen during MANIFEST generation they are mapped to .any.html, .any.worker.html, and .worker.html files as appropriate which WPTServe will generate on-the-fly. This allows for easy testing of [Exposed=(Window,Worker)] APIs and tests that are simply script with no boilerplate HTML. These are now supported in run-webkit-tests. When specifying tests to run, the source name should be specified, for example: $ run-webkit-test external/wpt/storage/interfaces.worker.js But expectations will use the generated name, e.g.: external/wpt/storage/interfaces.worker-expected.txt And failures will be reported under the generated name: external/wpt/storage/interfaces.worker.html BUG=653514 R=qyearsley@chromium.org

Patch Set 1 #

Patch Set 2 : Rebaselines for external/wpt/html/syntax/parsing/html5lib_* #

Patch Set 3 : Rebaseline worker.js tests #

Patch Set 4 : TestExpectations hacky fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1345 lines, -305 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker-expected.txt View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/IndexedDB/interfaces.worker-expected.txt View 1 2 1 chunk +174 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker-expected.txt View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/dom/interfaces.worker-expected.txt View 1 2 1 chunk +509 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/common-dom-interfaces/collections/domstringlist-interface.worker-expected.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_isindex-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_menuitem-element-expected.txt View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_template-expected.txt View 1 1 chunk +107 lines, -105 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests11-expected.txt View 1 1 chunk +8 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests19-expected.txt View 1 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests2-expected.txt View 1 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_tests25-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/syntax/parsing/html5lib_webkit02-expected.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/synthetic-errorevent-click.worker-expected.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/event-handler-processing-algorithm-error/workerglobalscope-synthetic-errorevent.worker-expected.txt View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.worker-expected.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/storage/interfaces.worker-expected.txt View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/constructors/Worker/DedicatedWorkerGlobalScope-members.worker-expected.txt View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/constructors/Worker/expected-self-properties.worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/interfaces.worker-expected.txt View 1 2 1 chunk +128 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/interfaces/WorkerUtils/importScripts/002.worker-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/semantics/interface-objects/001.worker-expected.txt View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/workers/semantics/interface-objects/002.worker-expected.txt View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +29 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_manifest.py View 1 2 3 2 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jsbell
Running locally, failures are in two classes: `*.worker.html` files which are now being run - ...
3 years, 9 months ago (2017-03-21 18:30:29 UTC) #1
jsbell
On 2017/03/21 18:30:29, jsbell wrote: > Files in html/syntax/parsing/html5lib_*' with the suffix `?run_type=XXX` where > ...
3 years, 9 months ago (2017-03-21 18:38:23 UTC) #2
jsbell
This should work and pass, with one exception... which is a tricky one: external/wpt/workers/nested_worker.worker.js This ...
3 years, 9 months ago (2017-03-21 19:16:41 UTC) #6
jsbell
Failures from the try run: external/wpt/html/dom/interfaces.worker.html - flaky? maybe I messed up the baseline? https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/413304/layout-test-results/external/wpt/html/dom/interfaces.worker-pretty-diff.html ...
3 years, 9 months ago (2017-03-21 21:00:52 UTC) #7
jeffcarp
On 2017/03/21 at 21:00:52, jsbell wrote: > Failures from the try run: > > external/wpt/html/dom/interfaces.worker.html ...
3 years, 9 months ago (2017-03-21 21:16:17 UTC) #8
jeffcarp
On 2017/03/21 at 21:16:17, jeffcarp wrote: > On 2017/03/21 at 21:00:52, jsbell wrote: > > ...
3 years, 9 months ago (2017-03-21 21:18:49 UTC) #9
qyearsley
3 years, 9 months ago (2017-03-21 21:19:35 UTC) #10
On 2017/03/21 at 21:16:17, jeffcarp wrote:
> On 2017/03/21 at 21:00:52, jsbell wrote:
> > Failures from the try run:
> > 
> > external/wpt/html/dom/interfaces.worker.html - flaky? maybe I messed up the
baseline?
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> > 
> > external/wpt/workers/nested_worker.worker.html - as expected
> 
> My only idea to get around this is to add special logic to
layout_tests.models.test_expectations.TestExpectationParser._lint_line for
*.any.html and *.worker.html tests (solving problem #2 above):
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

Hopefully, I don't think there needs to be special logic for ".any.html" and
".worker.html" in particular... but I think maybe we'll need to change the
semantics so that a "test" or "test path" is not the same as a "file" or "file
path" (more discussion in https://crbug.com/653514#c16).

Powered by Google App Engine
This is Rietveld 408576698