Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2767673002: WPTServe: Run .any.js and .worker.js variations (Closed)
Patch Set: TestExpectations hacky fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 503421ba1140a3f9f293e8168871b88e82144e46..d1454c580ca18460a5df7b098bf748573ddde339 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -751,6 +751,12 @@ class Port(object):
return WPTManifest('{}')
return WPTManifest(self._filesystem.read_text_file(manifest_path))
+ def is_wpt_test(self, test_entry):
+ match = re.match(r'external/wpt(/.*)', test_entry)
+ if not match:
+ return False
+ return self._wpt_manifest().is_test_url(match.group(1))
+
def is_slow_wpt_test(self, test_file):
match = re.match(r'external/wpt/(.*)', test_file)
if not match:
@@ -836,7 +842,7 @@ class Port(object):
"""Returns True if the test name refers to an existing test or baseline."""
# Used by test_expectations.py to determine if an entry refers to a
# valid test and by printing.py to determine if baselines exist.
- return self.test_isfile(test_name) or self.test_isdir(test_name)
+ return self.is_wpt_test(test_name) or self.test_isfile(test_name) or self.test_isdir(test_name)
def split_test(self, test_name):
"""Splits a test name into the 'directory' part and the 'basename' part."""

Powered by Google App Engine
This is Rietveld 408576698