Slightly reduce memory usage in OscillatorNode

Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700175
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.

Review-Url: https://codereview.chromium.org/2767623002
Cr-Commit-Position: refs/heads/master@{#466134}
Committed: https://chromium.googlesource.com/chromium/src/+/aa8cf68adc5654695f83f355d601eba127f16d75

[Raymond Toy, 2017-04-14 17:31:17]

Description was changed from

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, s PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" oscillator and
for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=70015
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

to

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=70015
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

[Raymond Toy, 2017-04-20 15:52:00]

Description was changed from

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=70015
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

to

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700715
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

[Raymond Toy, 2017-04-20 15:52:33]

Description was changed from

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700715
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

to

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700175
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

[Raymond Toy, 2017-04-20 15:53:58]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-20 15:53:58]

PTAL.

[hongchan, 2017-04-20 18:43:16]

lgtm

[Raymond Toy, 2017-04-20 19:04:32]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:05:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:14:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492715072929890,
"parent_rev": "df8804b62d42666ac585a090d745c09462ffe54e", "commit_rev":
"aa8cf68adc5654695f83f355d601eba127f16d75"}

[commit-bot: I haz the power, 2017-04-20 21:14:38]

Description was changed from

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700175
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.
==========

to

==========
Slightly reduce memory usage in OscillatorNode

When an OscillatorNode is created, a PeriodicWave is created for a
"sine" oscillator.  This is unavoidable when the factory method is
used.  However, with the constructor, the type of oscillator can be
specified and there is no need to create both a "sine" PeriodicWave
and one for the specified type.

Thus, for the constructor, only create the wave table for the
specified type.

BUG=700175
TEST=not testable; manually verifed with prints/debugger that sine
table is not created unless needed.

Review-Url: https://codereview.chromium.org/2767623002
Cr-Commit-Position: refs/heads/master@{#466134}
Committed:
https://chromium.googlesource.com/chromium/src/+/aa8cf68adc5654695f83f355d601...
==========

[commit-bot: I haz the power, 2017-04-20 21:14:38]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/aa8cf68adc5654695f83f355d601...